From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: "Kristian Høgsberg" <krh@bitplanet.net>
Cc: linux1394-devel@lists.sourceforge.net, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] ieee1394: sbp2: remove bogus "emulated" host flag
Date: Mon, 15 Jan 2007 21:49:51 +0100 (CET) [thread overview]
Message-ID: <tkrat.28a9be3ceb85c642@s5r6.in-berlin.de> (raw)
In-Reply-To: <59ad55d30701151141n72e3e99ey509d859c272b8bda@mail.gmail.com>
On 15 Jan, Kristian Høgsberg wrote:
> On 1/14/07, Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
>> There is no emulation going on here.
> ...
>
>> - .emulated = 1,
>
> Not sure what this flag does, but I copied it over to fw-sbp2.c.
There is a single use: Userspace application clients can look up the
value of this flag via the sg driver and can then come to whatever
conclusions.
> If it's bogus,
The flag was "half true" back in the times when sbp2 mangled a lot of
commands and responses to account for command sets behind the back of
the SCSI stack. That's not the case any more.
> I guess we should drop it from fw-sbp2.c too.
Yes. I merely didn't ready a patch because I currently want to
concentrate my SBP-2 related work on sbp2 and push relevant bits over to
fw-sbp2 some time later in one go, as far as you didn't do so already.
(I'll send a parallel fw-sbp2 patch too if something earthshaking comes
along.)
--
Stefan Richter
-=====-=-=== ---= -====
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2007-01-15 20:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-14 18:40 [PATCH] ieee1394: sbp2: remove bogus "emulated" host flag Stefan Richter
2007-01-15 19:41 ` Kristian Høgsberg
2007-01-15 20:40 ` Douglas Gilbert
2007-01-15 21:11 ` Kristian Høgsberg
2007-01-15 20:49 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.28a9be3ceb85c642@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=krh@bitplanet.net \
--cc=linux-scsi@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox