From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-scsi@vger.kernel.org
Subject: Re: dead CONFIG_ variables: drivers/scsi/
Date: Thu, 03 May 2007 13:35:56 +0200 [thread overview]
Message-ID: <4639C91C.9070204@s5r6.in-berlin.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0705030713210.680@localhost.localdomain>
Robert P. J. Day wrote:
[...]
>> > drivers/scsi/arm/acornscsi.c:70:#undef CONFIG_SCSI_ACORNSCSI_LINK
>> > drivers/scsi/arm/acornscsi.c:169:#ifdef CONFIG_SCSI_ACORNSCSI_LINK
[...]
> p.s. "CONFIG_" prefix aside, i would think it's also a bit yucky to
> be checking for the definition of a preprocessor symbol that you've
> already hardcoded out of existence in the same source file. :-)
These are basically #if 0 ... #endif blocks with an activation switch
conveniently placed at the top of the .c file. In the quoted example,
the effect of the activation switch is also documented by a comment.
Of course we should restrain ourselves WRT the use of #if 0 ... #endif
blocks in in-tree code, but sometimes they have sensible applications.
--
Stefan Richter
-=====-=-=== -=-= ---==
http://arcgraph.de/sr/
next prev parent reply other threads:[~2007-05-03 11:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-03 10:10 dead CONFIG_ variables: drivers/scsi/ Robert P. J. Day
2007-05-03 11:11 ` Russell King
2007-05-03 11:17 ` Robert P. J. Day
2007-05-03 11:22 ` Russell King
2007-05-03 11:35 ` Stefan Richter [this message]
2007-05-03 14:15 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4639C91C.9070204@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox