From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-scsi@vger.kernel.org
Subject: Re: dead CONFIG_ variables: drivers/scsi/
Date: Thu, 3 May 2007 07:17:34 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0705030713210.680@localhost.localdomain> (raw)
In-Reply-To: <20070503111113.GC12018@flint.arm.linux.org.uk>
On Thu, 3 May 2007, Russell King wrote:
> On Thu, May 03, 2007 at 06:10:28AM -0400, Robert P. J. Day wrote:
> >
> > $ ../dead_config.sh drivers/scsi
> > ========== ACORNSCSI_CONSTANTS ==========
> > drivers/scsi/arm/acornscsi.c:106:#undef CONFIG_ACORNSCSI_CONSTANTS
> > drivers/scsi/arm/acornscsi.c:417:#ifdef CONFIG_ACORNSCSI_CONSTANTS
> > drivers/scsi/arm/acornscsi.c:495:#ifdef CONFIG_ACORNSCSI_CONSTANTS
> > ========== SCSI_ACORNSCSI_LINK ==========
> > drivers/scsi/arm/acornscsi.c:70:#undef CONFIG_SCSI_ACORNSCSI_LINK
> > drivers/scsi/arm/acornscsi.c:169:#ifdef CONFIG_SCSI_ACORNSCSI_LINK
> > drivers/scsi/arm/acornscsi.c:1675:#ifdef CONFIG_SCSI_ACORNSCSI_LINK
> > drivers/scsi/arm/acornscsi.c:2849:#ifdef CONFIG_SCSI_ACORNSCSI_LINK
> > drivers/scsi/arm/acornscsi.c:2880:#ifdef CONFIG_SCSI_ACORNSCSI_LINK
>
> False positives. That #undef is preceded by a comment describing the
> driver-internal configuration for developers rather than users. I
> guess they shouldn't be preceded by CONFIG_.
i've already admitted that this script is going to generate false
positives for a number of reasons, the most common one being using the
"CONFIG_" prefix outside the context of Kconfig.
technically, of course, that doesn't hurt but it sure would make the
code clearer if that prefix was officially reserved for Kconfig stuff.
rday
p.s. "CONFIG_" prefix aside, i would think it's also a bit yucky to
be checking for the definition of a preprocessor symbol that you've
already hardcoded out of existence in the same source file. :-)
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
next prev parent reply other threads:[~2007-05-03 11:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-03 10:10 dead CONFIG_ variables: drivers/scsi/ Robert P. J. Day
2007-05-03 11:11 ` Russell King
2007-05-03 11:17 ` Robert P. J. Day [this message]
2007-05-03 11:22 ` Russell King
2007-05-03 11:35 ` Stefan Richter
2007-05-03 14:15 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0705030713210.680@localhost.localdomain \
--to=rpjday@mindspring.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox