* [PATCH] aacraid: add sysfs support for driver_version [not found] <AE4F746F2AECFC4DA4AADD66A1DFEF0189EB31@otce2k301.adaptec.com> @ 2007-06-19 19:49 ` Salyzyn, Mark 2007-06-19 20:27 ` Brian King 0 siblings, 1 reply; 3+ messages in thread From: Salyzyn, Mark @ 2007-06-19 19:49 UTC (permalink / raw) To: linux-scsi [-- Attachment #1: Type: text/plain, Size: 347 bytes --] Adding sysfs support for driver_version. This attached patch is against current scsi-misc-2.6 ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patch attachments. Signed-off-by: Mark Salyzyn <aacraid@adaptec.com> drivers/scsi/aacraid/linit.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) [-- Attachment #2: aacraid_sysfs_lld_version.patch --] [-- Type: application/octet-stream, Size: 1057 bytes --] diff -ru a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c --- a/drivers/scsi/aacraid/linit.c 2007-06-19 15:41:13.278400903 -0400 +++ b/drivers/scsi/aacraid/linit.c 2007-06-19 15:45:05.890172775 -0400 @@ -770,6 +770,12 @@ return len; } +static ssize_t aac_show_driver_version(struct class_device *class_dev, + char *buf) +{ + return snprintf(buf, PAGE_SIZE, "%s\n", aac_driver_version); +} + ssize_t aac_show_serial_number(struct class_device *class_dev, char *buf) { struct aac_dev *dev = (struct aac_dev*)class_to_shost(class_dev)->hostdata; @@ -861,6 +867,13 @@ }, .show = aac_show_bios_version, }; +static struct class_device_attribute aac_lld_version = { + .attr = { + .name = "driver_version", + .mode = S_IRUGO, + }, + .show = aac_show_driver_version, +}; static struct class_device_attribute aac_serial_number = { .attr = { .name = "serial_number", @@ -897,6 +910,7 @@ &aac_kernel_version, &aac_monitor_version, &aac_bios_version, + &aac_lld_version, &aac_serial_number, &aac_max_channel, &aac_max_id, ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] aacraid: add sysfs support for driver_version 2007-06-19 19:49 ` [PATCH] aacraid: add sysfs support for driver_version Salyzyn, Mark @ 2007-06-19 20:27 ` Brian King 2007-06-19 20:33 ` Salyzyn, Mark 0 siblings, 1 reply; 3+ messages in thread From: Brian King @ 2007-06-19 20:27 UTC (permalink / raw) To: Salyzyn, Mark; +Cc: linux-scsi Salyzyn, Mark wrote: > Adding sysfs support for driver_version. This is already available in /sys/module/aacraid/version Is this insufficient? -Brian -- Brian King Linux on Power Virtualization IBM Linux Technology Center ^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] aacraid: add sysfs support for driver_version 2007-06-19 20:27 ` Brian King @ 2007-06-19 20:33 ` Salyzyn, Mark 0 siblings, 0 replies; 3+ messages in thread From: Salyzyn, Mark @ 2007-06-19 20:33 UTC (permalink / raw) To: brking; +Cc: linux-scsi Thanks, consider this a NAK for this patch for current tree(s). Will retain for driver submissions for older 2.6 kernels (SLES9 for example) that do not have the /sys/module/ tree. Sincerely -- Mark Salyzyn > -----Original Message----- > From: Brian King [mailto:brking@linux.vnet.ibm.com] > Sent: Tuesday, June 19, 2007 4:27 PM > To: Salyzyn, Mark > Cc: linux-scsi@vger.kernel.org > Subject: Re: [PATCH] aacraid: add sysfs support for driver_version > > > Salyzyn, Mark wrote: > > Adding sysfs support for driver_version. > > This is already available in /sys/module/aacraid/version > > Is this insufficient? > > -Brian > > -- > Brian King > Linux on Power Virtualization > IBM Linux Technology Center > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-06-19 20:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <AE4F746F2AECFC4DA4AADD66A1DFEF0189EB31@otce2k301.adaptec.com>
2007-06-19 19:49 ` [PATCH] aacraid: add sysfs support for driver_version Salyzyn, Mark
2007-06-19 20:27 ` Brian King
2007-06-19 20:33 ` Salyzyn, Mark
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox