Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: sekharan@us.ibm.com
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	dm-devel@redhat.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/9] scsi_dh: Implement common device table handling
Date: Thu, 26 Jun 2008 14:45:48 +0200	[thread overview]
Message-ID: <48638F7C.9090602@suse.de> (raw)
In-Reply-To: <1214441566.32521.10.camel@chandra-ubuntu>

Hi Chandra,

Chandra Seetharaman wrote:
> Other than one minor issue the code looks good (sorry for the late
> realization on my part).
> 
> Issue: scsi_dh_handler_detach() references scsi_dh with no check for
> null and scsi_dh_notifier() call it with scsi_dh == NULL. code can be
> changed to get the device handler from sdev.
> 
This is fixed in patch 7/9. I thought I had rediffed them properly,
but apparently not. Sorry for that.

Thanks for the review.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)

  reply	other threads:[~2008-06-26 12:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-24 10:03 [PATCH 1/9] scsi_dh: Implement common device table handling Hannes Reinecke
2008-06-26  0:52 ` Chandra Seetharaman
2008-06-26 12:45   ` Hannes Reinecke [this message]
2008-06-26 14:41     ` Chandra Seetharaman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48638F7C.9090602@suse.de \
    --to=hare@suse.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sekharan@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox