From: Chandra Seetharaman <sekharan@us.ibm.com>
To: Hannes Reinecke <hare@suse.de>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
dm-devel@redhat.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/9] scsi_dh: Implement common device table handling
Date: Thu, 26 Jun 2008 07:41:03 -0700 [thread overview]
Message-ID: <1214491263.31845.0.camel@chandra-ubuntu> (raw)
In-Reply-To: <48638F7C.9090602@suse.de>
Great then.
Acked-by: Chandra Seetharaman <sekharan@us.ibm.com>
On Thu, 2008-06-26 at 14:45 +0200, Hannes Reinecke wrote:
> Hi Chandra,
>
> Chandra Seetharaman wrote:
> > Other than one minor issue the code looks good (sorry for the late
> > realization on my part).
> >
> > Issue: scsi_dh_handler_detach() references scsi_dh with no check for
> > null and scsi_dh_notifier() call it with scsi_dh == NULL. code can be
> > changed to get the device handler from sdev.
> >
> This is fixed in patch 7/9. I thought I had rediffed them properly,
> but apparently not. Sorry for that.
>
> Thanks for the review.
>
> Cheers,
>
> Hannes
prev parent reply other threads:[~2008-06-26 14:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 10:03 [PATCH 1/9] scsi_dh: Implement common device table handling Hannes Reinecke
2008-06-26 0:52 ` Chandra Seetharaman
2008-06-26 12:45 ` Hannes Reinecke
2008-06-26 14:41 ` Chandra Seetharaman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214491263.31845.0.camel@chandra-ubuntu \
--to=sekharan@us.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox