From: Mike Christie <michaelc@cs.wisc.edu>
To: Jayamohan Kalickal <jayamohank@serverengines.com>
Cc: linux-scsi@vger.kernel.org, James.Bottomley@suse.de
Subject: Re: [PATCH 1/1] be2iscsi: Fix for 64K data
Date: Thu, 15 Jul 2010 15:14:02 -0500 [thread overview]
Message-ID: <4C3F6C0A.5080502@cs.wisc.edu> (raw)
In-Reply-To: <20100714182749.GA25200@serverengines.com>
On 07/14/2010 01:28 PM, Jayamohan Kallickal wrote:
> This patch fixes a wraparound issue when the length=65536 for an sge.
> Since it was defined as a short, the length becomes zero
>
> This patch has been made over scsi-rc-fixes-2.6 tree pulled today
>
> Signed-off-by: Jayamohan Kallickal<jayamohank@serverengines.com>
> ---
> drivers/scsi/be2iscsi/be_main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
> index dd5b105..38e6d32 100644
> --- a/drivers/scsi/be2iscsi/be_main.c
> +++ b/drivers/scsi/be2iscsi/be_main.c
> @@ -1764,7 +1764,7 @@ hwi_write_sgl(struct iscsi_wrb *pwrb, struct scatterlist *sg,
> unsigned int num_sg, struct beiscsi_io_task *io_task)
> {
> struct iscsi_sge *psgl;
> - unsigned short sg_len, index;
> + unsigned int sg_len, index;
> unsigned int sge_len = 0;
> unsigned long long addr;
> struct scatterlist *l_sg;
Looks good.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
prev parent reply other threads:[~2010-07-15 20:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 18:28 [PATCH 1/1] be2iscsi: Fix for 64K data Jayamohan Kallickal
2010-07-15 20:14 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3F6C0A.5080502@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@suse.de \
--cc=jayamohank@serverengines.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox