* [PATCH 1/1] be2iscsi: Fix for 64K data
@ 2010-07-14 18:28 Jayamohan Kallickal
2010-07-15 20:14 ` Mike Christie
0 siblings, 1 reply; 2+ messages in thread
From: Jayamohan Kallickal @ 2010-07-14 18:28 UTC (permalink / raw)
To: linux-scsi; +Cc: James.Bottomley, michaelc
This patch fixes a wraparound issue when the length=65536 for an sge.
Since it was defined as a short, the length becomes zero
This patch has been made over scsi-rc-fixes-2.6 tree pulled today
Signed-off-by: Jayamohan Kallickal <jayamohank@serverengines.com>
---
drivers/scsi/be2iscsi/be_main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index dd5b105..38e6d32 100644
--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -1764,7 +1764,7 @@ hwi_write_sgl(struct iscsi_wrb *pwrb, struct scatterlist *sg,
unsigned int num_sg, struct beiscsi_io_task *io_task)
{
struct iscsi_sge *psgl;
- unsigned short sg_len, index;
+ unsigned int sg_len, index;
unsigned int sge_len = 0;
unsigned long long addr;
struct scatterlist *l_sg;
--
1.6.5.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] be2iscsi: Fix for 64K data
2010-07-14 18:28 [PATCH 1/1] be2iscsi: Fix for 64K data Jayamohan Kallickal
@ 2010-07-15 20:14 ` Mike Christie
0 siblings, 0 replies; 2+ messages in thread
From: Mike Christie @ 2010-07-15 20:14 UTC (permalink / raw)
To: Jayamohan Kalickal; +Cc: linux-scsi, James.Bottomley
On 07/14/2010 01:28 PM, Jayamohan Kallickal wrote:
> This patch fixes a wraparound issue when the length=65536 for an sge.
> Since it was defined as a short, the length becomes zero
>
> This patch has been made over scsi-rc-fixes-2.6 tree pulled today
>
> Signed-off-by: Jayamohan Kallickal<jayamohank@serverengines.com>
> ---
> drivers/scsi/be2iscsi/be_main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
> index dd5b105..38e6d32 100644
> --- a/drivers/scsi/be2iscsi/be_main.c
> +++ b/drivers/scsi/be2iscsi/be_main.c
> @@ -1764,7 +1764,7 @@ hwi_write_sgl(struct iscsi_wrb *pwrb, struct scatterlist *sg,
> unsigned int num_sg, struct beiscsi_io_task *io_task)
> {
> struct iscsi_sge *psgl;
> - unsigned short sg_len, index;
> + unsigned int sg_len, index;
> unsigned int sge_len = 0;
> unsigned long long addr;
> struct scatterlist *l_sg;
Looks good.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-15 20:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-14 18:28 [PATCH 1/1] be2iscsi: Fix for 64K data Jayamohan Kallickal
2010-07-15 20:14 ` Mike Christie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox