[PATCH 0/2] ISCSID: Added vlan field to the iface struct

[PATCH 0/2] ISCSID: Added vlan field to the iface struct

[Eddie Wai]

Hello,

This patch adds the iface.vlan field to the iface struct so that it
can be defined in the iface file.  This vlan field will then propagate
to both brcm_iscsiuio for nic_iface creation and bnx2i via the
iscsi_host_set_net_param path for ep_connect usage.

Another way is to do without the iscsi_host_set_net_param augmentation
and just keep track of it in brcm_iscsiuio.  So when the path req comes
through, brcm_iscsiuio will not need to search and just key off of the
current nic_iface.  But this approach might present a danger if we ever
goto separate out the threads in iscsid; hence losing synchronization.

For this, bnx2i will also need to be changed to accept set_host_param
callback for proper handling of the vlan message.

Please let me know what you think.  Thanks.

Eddie


Eddie Wai (2):
  ISCSID: Added vlan field to the iface struct
  ISCSID: Added ISCSI_HOST_PARAM_VLAN setting

 include/iscsi_if.h     |    1 +
 usr/config.h           |    4 ++++
 usr/iface.c            |   19 +++++++++++++++++--
 usr/iface.h            |    1 +
 usr/initiator_common.c |   10 ++++++++++
 usr/iscsi_settings.h   |    1 +
 6 files changed, 34 insertions(+), 2 deletions(-)

Re: [PATCH 0/2] ISCSID: Added vlan field to the iface struct

[Mike Christie]

On 03/10/2011 08:21 PM, Eddie Wai wrote:
> Hello,
>
> This patch adds the iface.vlan field to the iface struct so that it
> can be defined in the iface file.

Does qlogic's patches do what you wanted? Please review those patches 
and work with them to figure out what works for both of you guys.

Re: [PATCH 0/2] ISCSID: Added vlan field to the iface struct

[Eddie Wai]

On Sun, 2011-03-13 at 00:11 -0800, Mike Christie wrote:
> On 03/10/2011 08:21 PM, Eddie Wai wrote:
> > Hello,
> >
> > This patch adds the iface.vlan field to the iface struct so that it
> > can be defined in the iface file.
> 
> Does qlogic's patches do what you wanted? Please review those patches 
> and work with them to figure out what works for both of you guys.
> 
Yes, I think the overall strategy to send the transport the new net
params info for the offload adapter will work for our offload solution
as well.  Some of the parameters like vlan is exactly how we want it to
be sent down.  Others like subnetmask/gateway/etc. will have to be
parsed by uIP directly from the iface file instead.

All in all, it will work for us. Thanks.