Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Douglas Gilbert <dgilbert@interlog.com>
To: Hannes Reinecke <hare@suse.de>,
	"Elliott, Robert (Servers)" <elliott@hpe.com>,
	Bart Van Assche <bvanassche@acm.org>,
	Marc Gonzalez <marc.w.gonzalez@free.fr>,
	James Bottomley <jejb@linux.ibm.com>,
	Martin Petersen <martin.petersen@oracle.com>
Cc: SCSI <linux-scsi@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default
Date: Mon, 8 Jul 2019 09:02:23 -0400	[thread overview]
Message-ID: <5155c7bd-f339-33bb-1a84-18ea75963db2@interlog.com> (raw)
In-Reply-To: <284c3ecc-b3a8-eeec-92d5-5eda1f20f691@suse.de>

On 2019-07-08 2:01 a.m., Hannes Reinecke wrote:
> On 7/5/19 7:53 PM, Douglas Gilbert wrote:
>> On 2019-07-05 3:22 a.m., Hannes Reinecke wrote:
> [ .. ]
>>> As mentioned, rescan-scsi-bus.sh is keeping references to /proc/scsi as
>>> a fall back only, as it's meant to work kernel independent. Per default
>>> it'll be using /sys, and will happily work without /proc/scsi.
>>>
>>> So it's really only /proc/scsi/sg which carries some meaningful
>>> information; maybe we should move/copy it to somewhere else.
>>>
>>> I personally like getting rid of /proc/scsi.
>>
>> /proc/scsi/device_info doesn't seem to be in sysfs.
>>
>> Could the contents of /proc/scsi/sg/* be placed in
>> /sys/class/scsi_generic/* ? Currently that directory only has symlinks
>> to the sg devices.
>>
> The sg parameters are already available in /sys/module/sg/parameters;
> so from that perspective I feel we're good.

# ls /sys/module/sg/parameters/
allow_dio  def_reserved_size  scatter_elem_sz

# ls /proc/scsi/sg/
allow_dio  debug  def_reserved_size  device_hdr  devices  device_strs
red_debug  version

So that doesn't work, what are in 'parameters' are passed in at
module/driver initialization. Back to my original question: Could the
contents of /proc/scsi/sg/* be placed in /sys/class/scsi_generic/* ?

> Problem is /proc/scsi/device_info, for which we currently don't have any
> other location to store it at.
> Hmm.

Doug Gilbert

  parent reply	other threads:[~2019-07-08 13:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12 13:59 [PATCH v1] scsi: Don't select SCSI_PROC_FS by default Marc Gonzalez
2019-06-17 21:11 ` Bart Van Assche
2019-06-18  0:35   ` Douglas Gilbert
2019-06-18  1:08     ` Finn Thain
2019-06-18  7:29       ` Marc Gonzalez
2019-06-18 15:31         ` Douglas Gilbert
2019-06-19  9:42           ` Marc Gonzalez
2019-06-19 14:34             ` Douglas Gilbert
2019-06-20  9:01               ` Marc Gonzalez
2019-06-20 21:47                 ` Martin K. Petersen
2019-06-20 23:43                 ` Finn Thain
2019-06-21 10:41                   ` Marc Gonzalez
2019-06-21 23:50                     ` Finn Thain
2019-06-18  3:28     ` Bart Van Assche
2019-06-18 17:43       ` Elliott, Robert (Servers)
2019-07-05  7:22         ` Hannes Reinecke
2019-07-05 17:53           ` Douglas Gilbert
     [not found]             ` <284c3ecc-b3a8-eeec-92d5-5eda1f20f691@suse.de>
2019-07-08 13:02               ` Douglas Gilbert [this message]
2019-07-05  7:18       ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5155c7bd-f339-33bb-1a84-18ea75963db2@interlog.com \
    --to=dgilbert@interlog.com \
    --cc=bvanassche@acm.org \
    --cc=elliott@hpe.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=marc.w.gonzalez@free.fr \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox