Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>,
	James Bottomley <jejb@linux.ibm.com>,
	Martin Petersen <martin.petersen@oracle.com>
Cc: SCSI <linux-scsi@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>,
	Douglas Gilbert <dgilbert@interlog.com>
Subject: Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default
Date: Mon, 17 Jun 2019 14:11:06 -0700	[thread overview]
Message-ID: <621306ee-7ab6-9cd2-e934-94b3d6d731fc@acm.org> (raw)
In-Reply-To: <2de15293-b9be-4d41-bc67-a69417f27f7a@free.fr>

On 6/12/19 6:59 AM, Marc Gonzalez wrote:
> According to the option's help message, SCSI_PROC_FS has been
> superseded for ~15 years. Don't select it by default anymore.
> 
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> ---
>   drivers/scsi/Kconfig | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 73bce9b6d037..8c95e9ad6470 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -54,14 +54,11 @@ config SCSI_NETLINK
>   config SCSI_PROC_FS
>   	bool "legacy /proc/scsi/ support"
>   	depends on SCSI && PROC_FS
> -	default y
>   	---help---
>   	  This option enables support for the various files in
>   	  /proc/scsi.  In Linux 2.6 this has been superseded by
>   	  files in sysfs but many legacy applications rely on this.
>   
> -	  If unsure say Y.
> -
>   comment "SCSI support type (disk, tape, CD-ROM)"
>   	depends on SCSI

Hi Doug,

If I run grep "/proc/scsi" over the sg3_utils source code then grep 
reports 38 matches for that string. Does sg3_utils break with 
SCSI_PROC_FS=n?

Thanks,

Bart.

  reply	other threads:[~2019-06-17 21:11 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12 13:59 [PATCH v1] scsi: Don't select SCSI_PROC_FS by default Marc Gonzalez
2019-06-17 21:11 ` Bart Van Assche [this message]
2019-06-18  0:35   ` Douglas Gilbert
2019-06-18  1:08     ` Finn Thain
2019-06-18  7:29       ` Marc Gonzalez
2019-06-18 15:31         ` Douglas Gilbert
2019-06-19  9:42           ` Marc Gonzalez
2019-06-19 14:34             ` Douglas Gilbert
2019-06-20  9:01               ` Marc Gonzalez
2019-06-20 21:47                 ` Martin K. Petersen
2019-06-20 23:43                 ` Finn Thain
2019-06-21 10:41                   ` Marc Gonzalez
2019-06-21 23:50                     ` Finn Thain
2019-06-18  3:28     ` Bart Van Assche
2019-06-18 17:43       ` Elliott, Robert (Servers)
2019-07-05  7:22         ` Hannes Reinecke
2019-07-05 17:53           ` Douglas Gilbert
     [not found]             ` <284c3ecc-b3a8-eeec-92d5-5eda1f20f691@suse.de>
2019-07-08 13:02               ` Douglas Gilbert
2019-07-05  7:18       ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=621306ee-7ab6-9cd2-e934-94b3d6d731fc@acm.org \
    --to=bvanassche@acm.org \
    --cc=dgilbert@interlog.com \
    --cc=hch@lst.de \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=marc.w.gonzalez@free.fr \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox