From: Jack Wang <xjtuwjp@gmail.com>
To: Anand <anandkumar_santhanam@pmc-sierra.com>
Cc: linux-scsi@vger.kernel.org, Sangeetha.Gnanasekaran@pmcs.com,
Nikith.Ganigarakoppal@pmcs.com, Viswas.G@pmcs.com
Subject: Re: [PATCH V2 01/10] pm80xx: Device id changes to support series 8 controllers.
Date: Thu, 26 Sep 2013 08:39:45 +0200 [thread overview]
Message-ID: <5243D6B1.1060906@gmail.com> (raw)
In-Reply-To: <5243C5AD.3030607@pmc-sierra.com>
snip
> */
> payload.ase_sh_lm_slr_phyid = cpu_to_le32(SPINHOLD_DISABLE |
> LINKMODE_AUTO | LINKRATE_15 |
> - LINKRATE_30 | LINKRATE_60 | phy_id);
> + LINKRATE_30 | LINKRATE_60 | LINKRATE_120 | phy_id);
Is it safe to set 12g linkrate support also on 6g, if so, then :
Reviewed-by: Jack Wang <jinpu.wang@profitbricks.com>
> /* SSC Disable and SAS Analog ST configuration */
> /**
> payload.ase_sh_lm_slr_phyid =
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.h b/drivers/scsi/pm8001/pm80xx_hwi.h
> index 2b760ba..9a9116d 100644
> --- a/drivers/scsi/pm8001/pm80xx_hwi.h
> +++ b/drivers/scsi/pm8001/pm80xx_hwi.h
> @@ -168,6 +168,7 @@
> #define LINKRATE_15 (0x01 << 8)
> #define LINKRATE_30 (0x02 << 8)
> #define LINKRATE_60 (0x06 << 8)
> +#define LINKRATE_120 (0x08 << 8)
>
> /* Thermal related */
> #define THERMAL_ENABLE 0x1
> @@ -1223,10 +1224,10 @@ typedef struct SASProtocolTimerConfig SASProtocolTimerConfig_t;
>
> /* MSGU CONFIGURATION TABLE*/
>
> -#define SPCv_MSGU_CFG_TABLE_UPDATE 0x01
> -#define SPCv_MSGU_CFG_TABLE_RESET 0x02
> -#define SPCv_MSGU_CFG_TABLE_FREEZE 0x04
> -#define SPCv_MSGU_CFG_TABLE_UNFREEZE 0x08
> +#define SPCv_MSGU_CFG_TABLE_UPDATE 0x001
> +#define SPCv_MSGU_CFG_TABLE_RESET 0x002
> +#define SPCv_MSGU_CFG_TABLE_FREEZE 0x004
> +#define SPCv_MSGU_CFG_TABLE_UNFREEZE 0x008
> #define MSGU_IBDB_SET 0x00
> #define MSGU_HOST_INT_STATUS 0x08
> #define MSGU_HOST_INT_MASK 0x0C
>
next prev parent reply other threads:[~2013-09-26 6:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 5:27 [PATCH V2 01/10] pm80xx: Device id changes to support series 8 controllers Anand
2013-09-26 6:39 ` Jack Wang [this message]
2013-09-26 8:48 ` Sangeetha Gnanasekaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5243D6B1.1060906@gmail.com \
--to=xjtuwjp@gmail.com \
--cc=Nikith.Ganigarakoppal@pmcs.com \
--cc=Sangeetha.Gnanasekaran@pmcs.com \
--cc=Viswas.G@pmcs.com \
--cc=anandkumar_santhanam@pmc-sierra.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox