From: Jens Axboe <axboe@kernel.dk>
To: Tony Battersby <tonyb@cybernetics.com>,
linux-scsi@vger.kernel.org,
"James E.J. Bottomley" <JBottomley@parallels.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: Fix more error handling in SCSI_IOCTL_SEND_COMMAND
Date: Mon, 10 Nov 2014 15:43:48 -0700 [thread overview]
Message-ID: <54613FA4.8040802@kernel.dk> (raw)
In-Reply-To: <54613EC2.8010304@cybernetics.com>
On 2014-11-10 15:40, Tony Battersby wrote:
> Fix an error path in SCSI_IOCTL_SEND_COMMAND that calls
> blk_put_request(rq) on an invalid IS_ERR(rq) pointer.
>
> Fixes: a492f075450f ("block,scsi: fixup blk_get_request dead queue scenarios")
> Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
Thanks, good catch. Might be an idea to have blk_put_request() do
warn-and-return check on error pointers being passed in, just in case.
--
Jens Axboe
next prev parent reply other threads:[~2014-11-10 22:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 22:40 [PATCH] scsi: Fix more error handling in SCSI_IOCTL_SEND_COMMAND Tony Battersby
2014-11-10 22:43 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-10-23 19:10 Tony Battersby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54613FA4.8040802@kernel.dk \
--to=axboe@kernel.dk \
--cc=JBottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tonyb@cybernetics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox