From: Jens Axboe <axboe@fb.com>
To: Christoph Hellwig <hch@lst.de>
Cc: hare@suse.de, linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH, RFC] blk-mq: use a delayed work item for timeouts
Date: Mon, 12 Oct 2015 13:34:20 -0600 [thread overview]
Message-ID: <561C0B3C.70004@fb.com> (raw)
In-Reply-To: <1444678154-24766-1-git-send-email-hch@lst.de>
On 10/12/2015 01:29 PM, Christoph Hellwig wrote:
> For some pending NVMe work I'd really love to be able to get my timeouts
> from process context. So far it seems only SCSI and NVMe use the blk-mq
> timeout handler, and both don't seem to be particularly excited about
> being called from time context. Does anyone have an objection against
> the patch below that switches it to use a delayed work item? I could
> make use of this quickly for NVMe, but for SCSI we still have to deal
> with the old request code which can't be switched to a delayed work
> as easily.
No that's definitely fine with me, imho most error handling callbacks
should be in process context for ease of use in the driver.
--
Jens Axboe
next prev parent reply other threads:[~2015-10-12 19:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 19:29 [PATCH, RFC] blk-mq: use a delayed work item for timeouts Christoph Hellwig
2015-10-12 19:34 ` Jens Axboe [this message]
2015-10-12 20:08 ` Jens Axboe
2015-10-12 20:22 ` Christoph Hellwig
2015-10-12 20:26 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561C0B3C.70004@fb.com \
--to=axboe@fb.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox