From: Hannes Reinecke <hare@suse.de>
To: Benjamin Rood <benjaminjrood@gmail.com>,
linux-scsi@vger.kernel.org, xjtuwjp@gmail.com,
James.Bottomley@HansenPartnership.com
Cc: Benjamin Rood <brood@attotech.com>
Subject: Re: [PATCH 7/8] pm80xx: wait a minimum of 500ms before issuing commands to SPCv
Date: Mon, 2 Nov 2015 09:00:11 +0100 [thread overview]
Message-ID: <5637180B.3030003@suse.de> (raw)
In-Reply-To: <1446216811-2248-8-git-send-email-brood@attotech.com>
On 10/30/2015 03:53 PM, Benjamin Rood wrote:
> The documentation for the 8070 and 8072 SPCv chip explicitly states that
> a minimum of 500ms must elapse before issuing commands, otherwise the
> SPCv may not process them and the firmware may get into an unrecoverable
> state requiring a reboot. While the Linux guys will probably think this
> is 'racy', it is called out in the chip documentation and inserting this
> delay makes power management function properly.
>
> Signed-off-by: Benjamin Rood <brood@attotech.com>
> ---
> drivers/scsi/pm8001/pm8001_init.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
Can you please add a comment in the code, too?
Just to clarify why this is done, lest that someone else tries to
'optimize' this away.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-02 8:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 14:53 [PATCH 0/8] pm80xx: Add ATTO 12Gb HBA support and fix various issues Benjamin Rood
2015-10-30 14:53 ` [PATCH 1/8] pm80xx: configure PHY settings based on subsystem vendor ID Benjamin Rood
2015-11-02 7:51 ` Hannes Reinecke
2015-11-02 8:00 ` Jack Wang
2015-10-30 14:53 ` [PATCH 2/8] pm80xx: add support for PMC Sierra 8070 and PMC Sierra 8072 SAS controllers Benjamin Rood
2015-11-02 7:51 ` Hannes Reinecke
2015-11-02 8:01 ` Jack Wang
2015-10-30 14:53 ` [PATCH 3/8] pm80xx: add ATTO PCI IDs to pm8001_pci_table Benjamin Rood
2015-11-02 7:52 ` Hannes Reinecke
2015-11-02 8:02 ` Jack Wang
2015-10-30 14:53 ` [PATCH 4/8] pm80xx: add support for ATTO devices during SAS address initiailization Benjamin Rood
2015-11-02 7:53 ` Hannes Reinecke
2015-11-02 8:06 ` Jack Wang
2015-11-02 20:39 ` [PATCH v2 4/9] " Benjamin Rood
2015-10-30 14:53 ` [PATCH 5/8] pm80xx: set PHY profiles for ATTO 12Gb SAS controllers Benjamin Rood
2015-11-02 7:57 ` Hannes Reinecke
2015-11-02 8:08 ` Jack Wang
2015-10-30 14:53 ` [PATCH 6/8] pm80xx: do not examine registers for iButton feature if ATTO adapter Benjamin Rood
2015-11-02 7:58 ` Hannes Reinecke
2015-11-02 8:08 ` Jack Wang
2015-10-30 14:53 ` [PATCH 7/8] pm80xx: wait a minimum of 500ms before issuing commands to SPCv Benjamin Rood
2015-11-02 8:00 ` Hannes Reinecke [this message]
2015-11-02 8:12 ` Jack Wang
2015-11-02 20:42 ` [PATCH v2 7/9] " Benjamin Rood
2015-10-30 14:53 ` [PATCH 8/8] pm80xx: avoid a panic if MSI(X) interrupts are disabled Benjamin Rood
2015-11-02 8:01 ` Hannes Reinecke
2015-11-02 8:12 ` Jack Wang
2015-11-03 4:44 ` [PATCH 0/8] pm80xx: Add ATTO 12Gb HBA support and fix various issues Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5637180B.3030003@suse.de \
--to=hare@suse.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=benjaminjrood@gmail.com \
--cc=brood@attotech.com \
--cc=linux-scsi@vger.kernel.org \
--cc=xjtuwjp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox