From: Hannes Reinecke <hare@suse.de>
To: Bart Van Assche <bart.vanassche@sandisk.com>,
James Bottomley <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: James Smart <james.smart@avagotech.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] scsi_transport_fc: Unexport scsi_is_fc_vport()
Date: Tue, 29 Mar 2016 08:45:04 +0200 [thread overview]
Message-ID: <56FA2470.6000102@suse.de> (raw)
In-Reply-To: <56F9A418.5040607@sandisk.com>
On 03/28/2016 11:37 PM, Bart Van Assche wrote:
> Running the command "git grep -nHw scsi_is_fc_vport" shows that this
> function is only called from inside scsi_transport_fc.c. Hence unexport
> this function.
>
> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: James Smart <james.smart@avagotech.com>
> ---
> drivers/scsi/scsi_transport_fc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
> index 8a88226..90afe5d 100644
> --- a/drivers/scsi/scsi_transport_fc.c
> +++ b/drivers/scsi/scsi_transport_fc.c
> @@ -2027,11 +2027,10 @@ static void fc_vport_dev_release(struct device *dev)
> kfree(vport);
> }
>
> -int scsi_is_fc_vport(const struct device *dev)
> +static int scsi_is_fc_vport(const struct device *dev)
> {
> return dev->release == fc_vport_dev_release;
> }
> -EXPORT_SYMBOL(scsi_is_fc_vport);
>
> static int fc_vport_match(struct attribute_container *cont,
> struct device *dev)
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-03-29 6:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 21:37 [PATCH] scsi_transport_fc: Unexport scsi_is_fc_vport() Bart Van Assche
2016-03-29 6:45 ` Hannes Reinecke [this message]
2016-03-30 0:51 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FA2470.6000102@suse.de \
--to=hare@suse.de \
--cc=bart.vanassche@sandisk.com \
--cc=james.smart@avagotech.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox