* [PATCH] scsi_transport_fc: Unexport scsi_is_fc_vport()
@ 2016-03-28 21:37 Bart Van Assche
2016-03-29 6:45 ` Hannes Reinecke
2016-03-30 0:51 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Bart Van Assche @ 2016-03-28 21:37 UTC (permalink / raw)
To: James Bottomley, Martin K. Petersen
Cc: Hannes Reinecke, James Smart, linux-scsi@vger.kernel.org
Running the command "git grep -nHw scsi_is_fc_vport" shows that this
function is only called from inside scsi_transport_fc.c. Hence unexport
this function.
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Hannes Reinecke <hare@suse.de>
Cc: James Smart <james.smart@avagotech.com>
---
drivers/scsi/scsi_transport_fc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
index 8a88226..90afe5d 100644
--- a/drivers/scsi/scsi_transport_fc.c
+++ b/drivers/scsi/scsi_transport_fc.c
@@ -2027,11 +2027,10 @@ static void fc_vport_dev_release(struct device *dev)
kfree(vport);
}
-int scsi_is_fc_vport(const struct device *dev)
+static int scsi_is_fc_vport(const struct device *dev)
{
return dev->release == fc_vport_dev_release;
}
-EXPORT_SYMBOL(scsi_is_fc_vport);
static int fc_vport_match(struct attribute_container *cont,
struct device *dev)
--
2.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi_transport_fc: Unexport scsi_is_fc_vport()
2016-03-28 21:37 [PATCH] scsi_transport_fc: Unexport scsi_is_fc_vport() Bart Van Assche
@ 2016-03-29 6:45 ` Hannes Reinecke
2016-03-30 0:51 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Hannes Reinecke @ 2016-03-29 6:45 UTC (permalink / raw)
To: Bart Van Assche, James Bottomley, Martin K. Petersen
Cc: James Smart, linux-scsi@vger.kernel.org
On 03/28/2016 11:37 PM, Bart Van Assche wrote:
> Running the command "git grep -nHw scsi_is_fc_vport" shows that this
> function is only called from inside scsi_transport_fc.c. Hence unexport
> this function.
>
> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: James Smart <james.smart@avagotech.com>
> ---
> drivers/scsi/scsi_transport_fc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
> index 8a88226..90afe5d 100644
> --- a/drivers/scsi/scsi_transport_fc.c
> +++ b/drivers/scsi/scsi_transport_fc.c
> @@ -2027,11 +2027,10 @@ static void fc_vport_dev_release(struct device *dev)
> kfree(vport);
> }
>
> -int scsi_is_fc_vport(const struct device *dev)
> +static int scsi_is_fc_vport(const struct device *dev)
> {
> return dev->release == fc_vport_dev_release;
> }
> -EXPORT_SYMBOL(scsi_is_fc_vport);
>
> static int fc_vport_match(struct attribute_container *cont,
> struct device *dev)
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scsi_transport_fc: Unexport scsi_is_fc_vport()
2016-03-28 21:37 [PATCH] scsi_transport_fc: Unexport scsi_is_fc_vport() Bart Van Assche
2016-03-29 6:45 ` Hannes Reinecke
@ 2016-03-30 0:51 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2016-03-30 0:51 UTC (permalink / raw)
To: Bart Van Assche
Cc: James Bottomley, Martin K. Petersen, Hannes Reinecke, James Smart,
linux-scsi@vger.kernel.org
>>>>> "Bart" == Bart Van Assche <bart.vanassche@sandisk.com> writes:
Bart> Running the command "git grep -nHw scsi_is_fc_vport" shows that
Bart> this function is only called from inside
Bart> scsi_transport_fc.c. Hence unexport this function.
Applied to 4.7/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-30 0:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-28 21:37 [PATCH] scsi_transport_fc: Unexport scsi_is_fc_vport() Bart Van Assche
2016-03-29 6:45 ` Hannes Reinecke
2016-03-30 0:51 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox