From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>,
Sathya Prakash <sathya.prakash@broadcom.com>
Cc: Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
Ranjan Kumar <ranjan.kumar@broadcom.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: mpt3sas: validate variable event array spans
Date: Wed, 22 Jul 2026 07:32:08 -0400 [thread overview]
Message-ID: <576e129232cee62c82a559b4e6ec55b882da8a98.camel@HansenPartnership.com> (raw)
In-Reply-To: <20260722041257.1557-1-pengpeng@iscas.ac.cn>
On Wed, 2026-07-22 at 12:12 +0800, Pengpeng Hou wrote:
> SAS topology, PCIe topology and IR configuration events contain
> flexible arrays whose element counts are supplied by firmware. Their
> interrupt-time handlers use NumEntries or NumElements without first
> checking that the corresponding array fits in EventData.
Please explain why we might need to check this. The device is a fat
firmware one meaning the driver is usually set up with the correctly
matching limits to the ones the firmware returns.
Regards,
James
prev parent reply other threads:[~2026-07-22 11:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 4:12 [PATCH] scsi: mpt3sas: validate variable event array spans Pengpeng Hou
2026-07-22 4:27 ` sashiko-bot
2026-07-22 11:58 ` How to fix problems with the sashiko review model James Bottomley
2026-07-22 12:11 ` Laurent Pinchart
2026-07-22 12:42 ` James Bottomley
2026-07-22 13:08 ` Greg KH
2026-07-22 13:10 ` Greg KH
2026-07-22 13:45 ` James Bottomley
2026-07-22 14:08 ` Theodore Tso
2026-07-22 15:29 ` Miguel Ojeda
2026-07-22 13:42 ` James Bottomley
2026-07-22 14:00 ` Johannes Berg
2026-07-22 14:17 ` James Bottomley
2026-07-22 14:25 ` Johannes Berg
2026-07-22 15:39 ` Steven Rostedt
2026-07-22 15:55 ` James Bottomley
2026-07-22 16:36 ` Johannes Berg
2026-07-22 15:09 ` Mauro Carvalho Chehab
2026-07-22 15:24 ` James Bottomley
2026-07-22 20:25 ` Mauro Carvalho Chehab
2026-07-22 14:20 ` Mark Brown
2026-07-22 13:43 ` Guenter Roeck
2026-07-22 15:10 ` James Bottomley
2026-07-22 15:41 ` Miguel Ojeda
2026-07-22 15:54 ` Arnaldo Carvalho de Melo
2026-07-22 16:40 ` Roman Gushchin
2026-07-22 15:55 ` Roman Gushchin
2026-07-22 11:32 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576e129232cee62c82a559b4e6ec55b882da8a98.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=pengpeng@iscas.ac.cn \
--cc=ranjan.kumar@broadcom.com \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox