* [PATCH -next] scsi: ufs: Remove redundant dev_err call
@ 2022-09-23 10:12 Shang XiaoJing
2022-09-30 18:06 ` Bart Van Assche
2022-10-01 9:29 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Shang XiaoJing @ 2022-09-23 10:12 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, jejb, martin.petersen,
linux-arm-msm, linux-scsi
Cc: shangxiaojing
devm_ioremap_resource() prints error message in itself. Remove the
dev_err call to avoid redundant error message.
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
---
drivers/ufs/host/ufs-qcom-ice.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ufs/host/ufs-qcom-ice.c b/drivers/ufs/host/ufs-qcom-ice.c
index 745e48ec598f..62387ccd5b30 100644
--- a/drivers/ufs/host/ufs-qcom-ice.c
+++ b/drivers/ufs/host/ufs-qcom-ice.c
@@ -118,7 +118,6 @@ int ufs_qcom_ice_init(struct ufs_qcom_host *host)
host->ice_mmio = devm_ioremap_resource(dev, res);
if (IS_ERR(host->ice_mmio)) {
err = PTR_ERR(host->ice_mmio);
- dev_err(dev, "Failed to map ICE registers; err=%d\n", err);
return err;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] scsi: ufs: Remove redundant dev_err call
2022-09-23 10:12 [PATCH -next] scsi: ufs: Remove redundant dev_err call Shang XiaoJing
@ 2022-09-30 18:06 ` Bart Van Assche
2022-10-01 9:29 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Bart Van Assche @ 2022-09-30 18:06 UTC (permalink / raw)
To: Shang XiaoJing, agross, andersson, konrad.dybcio, jejb,
martin.petersen, linux-arm-msm, linux-scsi
On 9/23/22 03:12, Shang XiaoJing wrote:
> devm_ioremap_resource() prints error message in itself. Remove the
> dev_err call to avoid redundant error message.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] scsi: ufs: Remove redundant dev_err call
2022-09-23 10:12 [PATCH -next] scsi: ufs: Remove redundant dev_err call Shang XiaoJing
2022-09-30 18:06 ` Bart Van Assche
@ 2022-10-01 9:29 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-10-01 9:29 UTC (permalink / raw)
To: Shang XiaoJing
Cc: agross, andersson, konrad.dybcio, jejb, martin.petersen,
linux-arm-msm, linux-scsi
Shang,
> devm_ioremap_resource() prints error message in itself. Remove the
> dev_err call to avoid redundant error message.
Applied to 6.1/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-01 9:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-23 10:12 [PATCH -next] scsi: ufs: Remove redundant dev_err call Shang XiaoJing
2022-09-30 18:06 ` Bart Van Assche
2022-10-01 9:29 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox