From: John Garry <john.garry@huawei.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: <tyreld@linux.ibm.com>, <mpe@ellerman.id.au>,
<benh@kernel.crashing.org>, <paulus@samba.org>,
<jejb@linux.ibm.com>, <linux-scsi@vger.kernel.org>,
<linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
<hare@suse.de>, <bvanassche@acm.org>, <hch@lst.de>,
<linux-next@vger.kernel.org>, <sfr@canb.auug.org.au>
Subject: Re: [PATCH] scsi: ibmvfc: Stop using scsi_cmnd.tag
Date: Wed, 18 Aug 2021 12:29:10 +0100 [thread overview]
Message-ID: <69c51e23-48b9-4672-e559-d2e257ade29f@huawei.com> (raw)
In-Reply-To: <yq14kbnmqoh.fsf@ca-mkp.ca.oracle.com>
Hi Martin,
>
>> Use scsi_cmd_to_rq(scsi_cmnd)->tag in preference to scsi_cmnd.tag.
>
> Applied to 5.15/scsi-staging and rebased for bisectability.
>
Thanks, and sorry for the hassle. But I would still like the maintainers
to have a look, as I was curious about current usage of scsi_cmnd.tag in
that driver.
> Just to be picky it looks like there's another scsi_cmmd tag lurking in
> qla1280.c but it's sitting behind an #ifdef DEBUG_QLA1280.
>
That driver does not even compile with DEBUG_QLA1280 set beforehand.
I'll fix that up and send as separate patches in case you want to
shuffle the tag patch in earlier, which is prob not worth the effort.
I've done a good few more x86 randconfigs and tried to audit the code
for more references, so hopefully that's the last.
Thanks
next prev parent reply other threads:[~2021-08-18 11:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 13:43 [PATCH] scsi: ibmvfc: Stop using scsi_cmnd.tag John Garry
2021-08-18 2:31 ` Martin K. Petersen
2021-08-18 11:29 ` John Garry [this message]
2021-08-18 3:04 ` Bart Van Assche
2021-08-24 4:03 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69c51e23-48b9-4672-e559-d2e257ade29f@huawei.com \
--to=john.garry@huawei.com \
--cc=benh@kernel.crashing.org \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martin.petersen@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
--cc=tyreld@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox