Linux SCSI subsystem development
 help / color / mirror / Atom feed
* [PATCH] scsi: scsi_debug: Fix atomic write enable module param description
@ 2025-12-11 10:06 John Garry
  2025-12-11 19:04 ` Bart Van Assche
  2025-12-17  3:40 ` Martin K. Petersen
  0 siblings, 2 replies; 3+ messages in thread
From: John Garry @ 2025-12-11 10:06 UTC (permalink / raw)
  To: martin.petersen, james.bottomley; +Cc: linux-scsi, John Garry

The atomic write enable module param is "atomic_wr", and not
"atomic_write", so fix the module param description.

Fixes: 84f3a3c01d70 ("scsi: scsi_debug: Atomic write support")
Signed-off-by: John Garry <john.g.garry@oracle.com>

diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index b2ab97be5db3d..047d56d23beab 100644
--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -7410,7 +7410,7 @@ MODULE_PARM_DESC(lbprz,
 MODULE_PARM_DESC(lbpu, "enable LBP, support UNMAP command (def=0)");
 MODULE_PARM_DESC(lbpws, "enable LBP, support WRITE SAME(16) with UNMAP bit (def=0)");
 MODULE_PARM_DESC(lbpws10, "enable LBP, support WRITE SAME(10) with UNMAP bit (def=0)");
-MODULE_PARM_DESC(atomic_write, "enable ATOMIC WRITE support, support WRITE ATOMIC(16) (def=0)");
+MODULE_PARM_DESC(atomic_wr, "enable ATOMIC WRITE support, support WRITE ATOMIC(16) (def=0)");
 MODULE_PARM_DESC(lowest_aligned, "lowest aligned lba (def=0)");
 MODULE_PARM_DESC(lun_format, "LUN format: 0->peripheral (def); 1 --> flat address method");
 MODULE_PARM_DESC(max_luns, "number of LUNs per target to simulate(def=1)");
-- 
2.43.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: scsi_debug: Fix atomic write enable module param description
  2025-12-11 10:06 [PATCH] scsi: scsi_debug: Fix atomic write enable module param description John Garry
@ 2025-12-11 19:04 ` Bart Van Assche
  2025-12-17  3:40 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Bart Van Assche @ 2025-12-11 19:04 UTC (permalink / raw)
  To: John Garry, martin.petersen, james.bottomley; +Cc: linux-scsi

On 12/11/25 2:06 AM, John Garry wrote:
> The atomic write enable module param is "atomic_wr", and not
> "atomic_write", so fix the module param description.
> 
> Fixes: 84f3a3c01d70 ("scsi: scsi_debug: Atomic write support")
> Signed-off-by: John Garry <john.g.garry@oracle.com>
> 
> diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
> index b2ab97be5db3d..047d56d23beab 100644
> --- a/drivers/scsi/scsi_debug.c
> +++ b/drivers/scsi/scsi_debug.c
> @@ -7410,7 +7410,7 @@ MODULE_PARM_DESC(lbprz,
>   MODULE_PARM_DESC(lbpu, "enable LBP, support UNMAP command (def=0)");
>   MODULE_PARM_DESC(lbpws, "enable LBP, support WRITE SAME(16) with UNMAP bit (def=0)");
>   MODULE_PARM_DESC(lbpws10, "enable LBP, support WRITE SAME(10) with UNMAP bit (def=0)");
> -MODULE_PARM_DESC(atomic_write, "enable ATOMIC WRITE support, support WRITE ATOMIC(16) (def=0)");
> +MODULE_PARM_DESC(atomic_wr, "enable ATOMIC WRITE support, support WRITE ATOMIC(16) (def=0)");
>   MODULE_PARM_DESC(lowest_aligned, "lowest aligned lba (def=0)");
>   MODULE_PARM_DESC(lun_format, "LUN format: 0->peripheral (def); 1 --> flat address method");
>   MODULE_PARM_DESC(max_luns, "number of LUNs per target to simulate(def=1)");

Reviewed-by: Bart Van Assche <bvanassche@acm.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: scsi_debug: Fix atomic write enable module param description
  2025-12-11 10:06 [PATCH] scsi: scsi_debug: Fix atomic write enable module param description John Garry
  2025-12-11 19:04 ` Bart Van Assche
@ 2025-12-17  3:40 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2025-12-17  3:40 UTC (permalink / raw)
  To: james.bottomley, John Garry; +Cc: Martin K . Petersen, linux-scsi

On Thu, 11 Dec 2025 10:06:51 +0000, John Garry wrote:

> The atomic write enable module param is "atomic_wr", and not
> "atomic_write", so fix the module param description.
> 
> 

Applied to 6.19/scsi-fixes, thanks!

[1/1] scsi: scsi_debug: Fix atomic write enable module param description
      https://git.kernel.org/mkp/scsi/c/1f7d6e2efeed

-- 
Martin K. Petersen

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-12-17  3:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-11 10:06 [PATCH] scsi: scsi_debug: Fix atomic write enable module param description John Garry
2025-12-11 19:04 ` Bart Van Assche
2025-12-17  3:40 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox