Re: [PATCH v2 0/3] scsi: ufs: Harden TX EQTR error handling paths

[Ziqi Chen <ziqi.chen@oss.qualcomm.com>]

On 6/25/2026 8:13 PM, Can Guo wrote:
> TX Equalization training currently has a few error-path gaps that can
> make the flow brittle and can leave variant/device cleanup incomplete.
>
> This series hardens TX EQTR in three places:
>
> 1. ufs-qcom: route SW FOM setup failures through the shared cleanup path
>     so temporary device TX EQ settings are restored and link recovery is
>     always attempted before exit.
> 2. core: treat RX_FOM DME read failures as best effort so TX EQTR can
>     continue, and force failed lanes to deterministic 0 FOM.
> 3. core: always run tx_eqtr POST_CHANGE notify once PRE_CHANGE succeeds,
>     even when TX EQTR fails, so variant cleanup is not skipped.
>
> Together these changes improve TX EQTR robustness without changing the
> normal success path.
>
> Dependency note:
> PATCH 3/3 depends on the patch below, which is still under review:
> https://lore.kernel.org/all/c71af930-c7b4-4480-b125-f35cbe35a16f@oss.qualcomm.com/
>
> Please apply this series on top of that patch (or a tree containing it).
>
> v1 -> v2:
> - Adopted Peter's comment (Patch 2)
>
> Can Guo (3):
>    scsi: ufs: ufs-qcom: Restore TX Equalization settings on FOM failure
>    scsi: ufs: core: Tolerate RX_FOM read failures in TX EQTR
>    scsi: ufs: core: Always run tx_eqtr POST_CHANGE notify
>
>   drivers/ufs/core/ufs-txeq.c | 33 ++++++++++++++++++++++++---------
>   drivers/ufs/host/ufs-qcom.c |  9 ++++-----
>   2 files changed, 28 insertions(+), 14 deletions(-)
Reviewed-by: Ziqi Chen <ziqi.chen@oss.qualcomm.com>