Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Jason Yan <yanaijie@huawei.com>
To: John Garry <john.g.garry@oracle.com>,
	yangxingui <yangxingui@huawei.com>, <jejb@linux.ibm.com>,
	<martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linuxarm@huawei.com>, <liyihang9@h-partners.com>,
	<liuyonglong@huawei.com>, <kangfenglong@huawei.com>
Subject: Re: [PATCH] Revert "scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed"
Date: Mon, 1 Dec 2025 21:27:49 +0800	[thread overview]
Message-ID: <78a9384c-7a1d-43b7-a16f-d0bc6863fd1e@huawei.com> (raw)
In-Reply-To: <1c2341ae-ffda-412a-af7f-5458e621fa33@oracle.com>

在 2025/12/1 20:51, John Garry 写道:
> On 27/11/2025 07:27, yangxingui wrote:
>> Hi, John
>>
>> I'm glad to receive your reply.
>>
>> On 2025/11/27 14:47, John Garry wrote:
>>> On 27/11/2025 00:59, yangxingui wrote:
>>>> Kindly ping for upstream.
>>>>
>>>> On 2025/10/21 15:34, Xingui Yang wrote:
>>>
>>> Your reasons for revert is light on details.
>>>
>>>>> This reverts commit ab2068a6fb84751836a84c26ca72b3beb349619d.
>>>>>
>>>>> As the disk may fall into an abnormal loop of probe when it fails 
>>>>> to probe
>>>>> due to physical reasons and cannot be repaired.
>>>
>>> So for a faulty disk we get into a indefinite loop, right?
>> Yes, because a hard reset for SATA disk is executed during the error 
>> handler, a BC event will be received after the disk probe fails, and 
>> the probe will be re-executed on the disk.
> 
> You need to add these details to the commit log.
> 
>>>
>>> What about case where this was helping before?
>> A temporary fault injected into the disk or link, which can be 
>> recovered after a short time.
> 
> I'm ok with this if Jason is...

I think we can merge this patch first and fix the previous issue later 
because this issue is more critical. So:

Reviewed-by: Jason Yan <yanaijie@huawei.com>

  reply	other threads:[~2025-12-01 13:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-21  7:34 [PATCH] Revert "scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed" Xingui Yang
2025-11-27  0:59 ` yangxingui
2025-11-27  6:47   ` John Garry
2025-11-27  7:27     ` yangxingui
2025-12-01 12:51       ` John Garry
2025-12-01 13:27         ` Jason Yan [this message]
2025-12-02  7:00           ` yangxingui
2025-11-27  7:21 ` Jason Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78a9384c-7a1d-43b7-a16f-d0bc6863fd1e@huawei.com \
    --to=yanaijie@huawei.com \
    --cc=jejb@linux.ibm.com \
    --cc=john.g.garry@oracle.com \
    --cc=kangfenglong@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=liuyonglong@huawei.com \
    --cc=liyihang9@h-partners.com \
    --cc=martin.petersen@oracle.com \
    --cc=yangxingui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox