Re: [PATCH] Revert "scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed"

[yangxingui <yangxingui@huawei.com>]

On 2025/12/1 21:27, Jason Yan wrote:
> 在 2025/12/1 20:51, John Garry 写道:
>> On 27/11/2025 07:27, yangxingui wrote:
>>> Hi, John
>>>
>>> I'm glad to receive your reply.
>>>
>>> On 2025/11/27 14:47, John Garry wrote:
>>>> On 27/11/2025 00:59, yangxingui wrote:
>>>>> Kindly ping for upstream.
>>>>>
>>>>> On 2025/10/21 15:34, Xingui Yang wrote:
>>>>
>>>> Your reasons for revert is light on details.
>>>>
>>>>>> This reverts commit ab2068a6fb84751836a84c26ca72b3beb349619d.
>>>>>>
>>>>>> As the disk may fall into an abnormal loop of probe when it fails 
>>>>>> to probe
>>>>>> due to physical reasons and cannot be repaired.
>>>>
>>>> So for a faulty disk we get into a indefinite loop, right?
>>> Yes, because a hard reset for SATA disk is executed during the error 
>>> handler, a BC event will be received after the disk probe fails, and 
>>> the probe will be re-executed on the disk.
>>
>> You need to add these details to the commit log.
>>
>>>>
>>>> What about case where this was helping before?
>>> A temporary fault injected into the disk or link, which can be 
>>> recovered after a short time.
>>
>> I'm ok with this if Jason is...
> 
> I think we can merge this patch first and fix the previous issue later 
> because this issue is more critical. So:
> 
> Reviewed-by: Jason Yan <yanaijie@huawei.com>
> .

Ok, I have resent a new version and update the commit log.

Thanks,
Xingui
.