* [PATCH] Revert "scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed" @ 2025-10-21 7:34 Xingui Yang 2025-11-27 0:59 ` yangxingui 2025-11-27 7:21 ` Jason Yan 0 siblings, 2 replies; 8+ messages in thread From: Xingui Yang @ 2025-10-21 7:34 UTC (permalink / raw) To: john.g.garry, yanaijie, jejb, martin.petersen Cc: linux-scsi, linux-kernel, linuxarm, liyihang9, yangxingui, liuyonglong, kangfenglong This reverts commit ab2068a6fb84751836a84c26ca72b3beb349619d. As the disk may fall into an abnormal loop of probe when it fails to probe due to physical reasons and cannot be repaired. Signed-off-by: Xingui Yang <yangxingui@huawei.com> --- drivers/scsi/libsas/sas_internal.h | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/scsi/libsas/sas_internal.h b/drivers/scsi/libsas/sas_internal.h index 03d6ec1eb970..85948963fb97 100644 --- a/drivers/scsi/libsas/sas_internal.h +++ b/drivers/scsi/libsas/sas_internal.h @@ -145,20 +145,6 @@ static inline void sas_fail_probe(struct domain_device *dev, const char *func, i func, dev->parent ? "exp-attached" : "direct-attached", SAS_ADDR(dev->sas_addr), err); - - /* - * If the device probe failed, the expander phy attached address - * needs to be reset so that the phy will not be treated as flutter - * in the next revalidation - */ - if (dev->parent && !dev_is_expander(dev->dev_type)) { - struct sas_phy *phy = dev->phy; - struct domain_device *parent = dev->parent; - struct ex_phy *ex_phy = &parent->ex_dev.ex_phy[phy->number]; - - memset(ex_phy->attached_sas_addr, 0, SAS_ADDR_SIZE); - } - sas_unregister_dev(dev->port, dev); } -- 2.33.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] Revert "scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed" 2025-10-21 7:34 [PATCH] Revert "scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed" Xingui Yang @ 2025-11-27 0:59 ` yangxingui 2025-11-27 6:47 ` John Garry 2025-11-27 7:21 ` Jason Yan 1 sibling, 1 reply; 8+ messages in thread From: yangxingui @ 2025-11-27 0:59 UTC (permalink / raw) To: john.g.garry, yanaijie, jejb, martin.petersen Cc: linux-scsi, linux-kernel, linuxarm, liyihang9, liuyonglong, kangfenglong Kindly ping for upstream. On 2025/10/21 15:34, Xingui Yang wrote: > This reverts commit ab2068a6fb84751836a84c26ca72b3beb349619d. > > As the disk may fall into an abnormal loop of probe when it fails to probe > due to physical reasons and cannot be repaired. > > Signed-off-by: Xingui Yang <yangxingui@huawei.com> > --- > drivers/scsi/libsas/sas_internal.h | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/drivers/scsi/libsas/sas_internal.h b/drivers/scsi/libsas/sas_internal.h > index 03d6ec1eb970..85948963fb97 100644 > --- a/drivers/scsi/libsas/sas_internal.h > +++ b/drivers/scsi/libsas/sas_internal.h > @@ -145,20 +145,6 @@ static inline void sas_fail_probe(struct domain_device *dev, const char *func, i > func, dev->parent ? "exp-attached" : > "direct-attached", > SAS_ADDR(dev->sas_addr), err); > - > - /* > - * If the device probe failed, the expander phy attached address > - * needs to be reset so that the phy will not be treated as flutter > - * in the next revalidation > - */ > - if (dev->parent && !dev_is_expander(dev->dev_type)) { > - struct sas_phy *phy = dev->phy; > - struct domain_device *parent = dev->parent; > - struct ex_phy *ex_phy = &parent->ex_dev.ex_phy[phy->number]; > - > - memset(ex_phy->attached_sas_addr, 0, SAS_ADDR_SIZE); > - } > - > sas_unregister_dev(dev->port, dev); > } > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Revert "scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed" 2025-11-27 0:59 ` yangxingui @ 2025-11-27 6:47 ` John Garry 2025-11-27 7:27 ` yangxingui 0 siblings, 1 reply; 8+ messages in thread From: John Garry @ 2025-11-27 6:47 UTC (permalink / raw) To: yangxingui, yanaijie, jejb, martin.petersen Cc: linux-scsi, linux-kernel, linuxarm, liyihang9, liuyonglong, kangfenglong On 27/11/2025 00:59, yangxingui wrote: > Kindly ping for upstream. > > On 2025/10/21 15:34, Xingui Yang wrote: Your reasons for revert is light on details. >> This reverts commit ab2068a6fb84751836a84c26ca72b3beb349619d. >> >> As the disk may fall into an abnormal loop of probe when it fails to >> probe >> due to physical reasons and cannot be repaired. So for a faulty disk we get into a indefinite loop, right? What about case where this was helping before? >> >> Signed-off-by: Xingui Yang <yangxingui@huawei.com> >> --- >> drivers/scsi/libsas/sas_internal.h | 14 -------------- >> 1 file changed, 14 deletions(-) >> >> diff --git a/drivers/scsi/libsas/sas_internal.h b/drivers/scsi/libsas/ >> sas_internal.h >> index 03d6ec1eb970..85948963fb97 100644 >> --- a/drivers/scsi/libsas/sas_internal.h >> +++ b/drivers/scsi/libsas/sas_internal.h >> @@ -145,20 +145,6 @@ static inline void sas_fail_probe(struct >> domain_device *dev, const char *func, i >> func, dev->parent ? "exp-attached" : >> "direct-attached", >> SAS_ADDR(dev->sas_addr), err); >> - >> - /* >> - * If the device probe failed, the expander phy attached address >> - * needs to be reset so that the phy will not be treated as flutter >> - * in the next revalidation >> - */ >> - if (dev->parent && !dev_is_expander(dev->dev_type)) { >> - struct sas_phy *phy = dev->phy; >> - struct domain_device *parent = dev->parent; >> - struct ex_phy *ex_phy = &parent->ex_dev.ex_phy[phy->number]; >> - >> - memset(ex_phy->attached_sas_addr, 0, SAS_ADDR_SIZE); >> - } >> - >> sas_unregister_dev(dev->port, dev); >> } >> > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Revert "scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed" 2025-11-27 6:47 ` John Garry @ 2025-11-27 7:27 ` yangxingui 2025-12-01 12:51 ` John Garry 0 siblings, 1 reply; 8+ messages in thread From: yangxingui @ 2025-11-27 7:27 UTC (permalink / raw) To: John Garry, yanaijie, jejb, martin.petersen Cc: linux-scsi, linux-kernel, linuxarm, liyihang9, liuyonglong, kangfenglong Hi, John I'm glad to receive your reply. On 2025/11/27 14:47, John Garry wrote: > On 27/11/2025 00:59, yangxingui wrote: >> Kindly ping for upstream. >> >> On 2025/10/21 15:34, Xingui Yang wrote: > > Your reasons for revert is light on details. > >>> This reverts commit ab2068a6fb84751836a84c26ca72b3beb349619d. >>> >>> As the disk may fall into an abnormal loop of probe when it fails to >>> probe >>> due to physical reasons and cannot be repaired. > > So for a faulty disk we get into a indefinite loop, right? Yes, because a hard reset for SATA disk is executed during the error handler, a BC event will be received after the disk probe fails, and the probe will be re-executed on the disk. > > What about case where this was helping before? A temporary fault injected into the disk or link, which can be recovered after a short time. log before: [49495.065650] sas: broadcast received: 0 [49495.065661] sas: REVALIDATING DOMAIN on port 0, pid:318259 [49495.066190] sas: Expander phy change count has changed [49495.068368] sas: ex 500e004aaaaaaa1f phy2 originated BROADCAST(CHANGE) [49495.068369] sas: ex 500e004aaaaaaa1f phy2 new device attached [49495.068434] sas: ex 500e004aaaaaaa1f phy02:U:9 attached: 500e004aaaaaaa02 (stp) [49495.090453] hisi_sas_v3_hw 0000:b4:02.0: dev[698:5] found [49495.266248] sas: done REVALIDATING DOMAIN on port 0, pid:318259, res 0x0 [49495.271115] sas: Enter sas_scsi_recover_host busy: 0 failed: 0 [49495.271129] sas: ata761: end_device-6:3:0: dev error handler [49495.271133] sas: ata762: end_device-6:3:1: dev error handler [49495.271136] sas: ata764: end_device-6:3:3: dev error handler [49495.271170] sas: ata765: end_device-6:3:4: dev error handler [49495.271171] sas: ata768: end_device-6:3:5: dev error handler [49495.271173] sas: ata769: end_device-6:3:2: dev error handler [49497.465030] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4081 task=0000000054417d4d dev id=698 sas_addr=0x500e004aaaaaaa02 CQ hdr: 0x101b 0x2ba0ff1 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 [49497.503517] sas: sas_to_ata_err: Saw error 135. What to do? [49497.503518] sas: sas_ata_task_done: SAS error 87 [49497.503546] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4082 task=00000000972479c8 dev id=698 sas_addr=0x500e004aaaaaaa02 CQ hdr: 0x203 0x2ba0ff2 0x0 0x100 Error info: 0x0 0x0 0x0 0x0 [49497.542451] ata769.00: failed to IDENTIFY (I/O error, err_mask=0x4) [49502.713074] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4005 task=00000000be2e16ae dev id=698 sas_addr=0x500e004aaaaaaa02 CQ hdr: 0x101b 0x2ba0fa5 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 [49502.752805] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed [49502.767384] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4006 task=00000000be2e16ae dev id=698 sas_addr=0x500e004aaaaaaa02 CQ hdr: 0x101b 0x2ba0fa6 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 [49502.807336] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed [49502.821449] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4007 task=00000000be2e16ae dev id=698 sas_addr=0x500e004aaaaaaa02 CQ hdr: 0x101b 0x2ba0fa7 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 [49502.861361] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed [49502.875664] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: executing internal task failed! [49502.898556] hisi_sas_v3_hw 0000:b4:02.0: ata disk reset failed [49502.912015] hisi_sas_v3_hw 0000:b4:02.0: I_T nexus reset: softreset failed (-5) [49505.112967] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4010 task=00000000be2e16ae dev id=698 sas_addr=0x500e004aaaaaaa02 CQ hdr: 0x203 0x2ba0faa 0x0 0x100 Error info: 0x0 0x0 0x0 0x0 [49505.153594] ata769.00: failed to IDENTIFY (I/O error, err_mask=0x4) [49510.137044] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4027 task=00000000d6273fa9 dev id=698 sas_addr=0x500e004aaaaaaa02 CQ hdr: 0x101b 0x2ba0fbb 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 [49510.178227] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed [49510.193284] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4028 task=00000000d6273fa9 dev id=698 sas_addr=0x500e004aaaaaaa02 CQ hdr: 0x101b 0x2ba0fbc 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 [49510.234190] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed [49510.248603] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4029 task=00000000d6273fa9 dev id=698 sas_addr=0x500e004aaaaaaa02 CQ hdr: 0x101b 0x2ba0fbd 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 [49510.288968] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed [49510.303156] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: executing internal task failed! [49510.325863] hisi_sas_v3_hw 0000:b4:02.0: ata disk reset failed [49510.339230] hisi_sas_v3_hw 0000:b4:02.0: I_T nexus reset: softreset failed (-5) [49512.536979] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4032 task=00000000d6273fa9 dev id=698 sas_addr=0x500e004aaaaaaa02 CQ hdr: 0x203 0x2ba0fc0 0x0 0x100 Error info: 0x0 0x0 0x0 0x0 [49512.577050] ata769.00: failed to IDENTIFY (I/O error, err_mask=0x4) [49517.561046] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4050 task=0000000070019bd9 dev id=698 sas_addr=0x500e004aaaaaaa02 CQ hdr: 0x101b 0x2ba0fd2 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 [49517.601923] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed [49517.616945] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4051 task=0000000070019bd9 dev id=698 sas_addr=0x500e004aaaaaaa02 CQ hdr: 0x101b 0x2ba0fd3 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 [49517.657745] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed [49517.672097] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4052 task=0000000070019bd9 dev id=698 sas_addr=0x500e004aaaaaaa02 CQ hdr: 0x101b 0x2ba0fd4 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 [49517.712567] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed [49517.726756] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: executing internal task failed! [49517.749459] hisi_sas_v3_hw 0000:b4:02.0: ata disk reset failed [49517.762828] hisi_sas_v3_hw 0000:b4:02.0: I_T nexus reset: softreset failed (-5) [49519.960965] sas: --- Exit sas_scsi_recover_host: busy: 0 failed: 0 tries: 1 [49519.971018] sas: sas_probe_sata: for exp-attached device 500e004aaaaaaa02 returned -19 [49519.971039] hisi_sas_v3_hw 0000:b4:02.0: dev[698:5] is gone [49519.984864] sas: broadcast received: 0 [49519.984876] sas: REVALIDATING DOMAIN on port 0, pid:318259 [49519.985362] sas: Expander phy change count has changed [49519.987278] sas: ex 500e004aaaaaaa1f phy2 originated BROADCAST(CHANGE) [49519.987442] sas: ex 500e004aaaaaaa1f phy02:U:A attached: 500e004aaaaaaa02 (stp) [49519.987443] sas: ex 500e004aaaaaaa1f phy 0x2 broadcast flutter [49519.987448] sas: done REVALIDATING DOMAIN on port 0, pid:318259, res 0x0 log new after apply the patch: [70734.380100] sas: broadcast received: 0 [70734.380110] sas: REVALIDATING DOMAIN on port 0, pid:311546 [70734.380431] sas: Expander phy change count has changed [70734.382191] sas: ex 500e004aaaaaaa1f phy0 originated BROADCAST(CHANGE) [70734.382193] sas: ex 500e004aaaaaaa1f phy0 new device attached [70734.382262] sas: ex 500e004aaaaaaa1f phy00:U:9 attached: 500e004aaaaaaa00 (stp) [70734.402596] hisi_sas_v3_hw 0000:b4:02.0: dev[18:5] found [70734.574064] sas: done REVALIDATING DOMAIN on port 0, pid:311546, res 0x0 [70734.580049] sas: Enter sas_scsi_recover_host busy: 0 failed: 0 [70734.580064] sas: ata370: end_device-7:0:4: dev error handler [70734.580066] sas: ata371: end_device-7:0:5: dev error handler [70734.580071] sas: ata373: end_device-7:0:1: dev error handler [70734.580075] sas: ata374: end_device-7:0:2: dev error handler [70734.580076] sas: ata375: end_device-7:0:3: dev error handler [70734.580077] sas: ata376: end_device-7:0:0: dev error handler [70736.776755] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4013 task=00000000113fa417 dev id=18 sas_addr=0x500e004aaaaaaa00 CQ hdr: 0x101b 0x120fad 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 [70736.813168] sas: sas_to_ata_err: Saw error 135. What to do? [70736.813169] sas: sas_ata_task_done: SAS error 87 [70736.813201] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4014 task=0000000037bc53e5 dev id=18 sas_addr=0x500e004aaaaaaa00 CQ hdr: 0x203 0x120fae 0x0 0x100 Error info: 0x0 0x0 0x0 0x0 [70736.850261] ata376.00: failed to IDENTIFY (I/O error, err_mask=0x4) [70741.992742] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4032 task=00000000fe3b3918 dev id=18 sas_addr=0x500e004aaaaaaa00 CQ hdr: 0x101b 0x120fc0 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 [70742.030820] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed [70742.044539] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4033 task=00000000fe3b3918 dev id=18 sas_addr=0x500e004aaaaaaa00 CQ hdr: 0x101b 0x120fc1 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 [70742.083611] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed [70742.097548] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4034 task=00000000fe3b3918 dev id=18 sas_addr=0x500e004aaaaaaa00 CQ hdr: 0x101b 0x120fc2 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 [70742.137553] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed [70742.151829] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: executing internal task failed! [70742.174491] hisi_sas_v3_hw 0000:b4:02.0: ata disk reset failed [70742.187938] hisi_sas_v3_hw 0000:b4:02.0: I_T nexus reset: softreset failed (-5) [70744.392769] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4037 task=00000000fe3b3918 dev id=18 sas_addr=0x500e004aaaaaaa00 CQ hdr: 0x203 0x120fc5 0x0 0x100 Error info: 0x0 0x0 0x0 0x0 [70744.433129] ata376.00: failed to IDENTIFY (I/O error, err_mask=0x4) [70749.416741] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4055 task=000000005dbdb66e dev id=18 sas_addr=0x500e004aaaaaaa00 CQ hdr: 0x101b 0x120fd7 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 [70749.457819] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed [70749.472339] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4056 task=000000005dbdb66e dev id=18 sas_addr=0x500e004aaaaaaa00 CQ hdr: 0x101b 0x120fd8 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 [70749.513046] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed [70749.527425] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4057 task=000000005dbdb66e dev id=18 sas_addr=0x500e004aaaaaaa00 CQ hdr: 0x101b 0x120fd9 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 [70749.567887] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed [70749.582146] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: executing internal task failed! [70749.604974] hisi_sas_v3_hw 0000:b4:02.0: ata disk reset failed [70749.618406] hisi_sas_v3_hw 0000:b4:02.0: I_T nexus reset: softreset failed (-5) [70751.816753] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4061 task=000000005dbdb66e dev id=18 sas_addr=0x500e004aaaaaaa00 CQ hdr: 0x203 0x120fdd 0x0 0x100 Error info: 0x0 0x0 0x0 0x0 [70751.856789] ata376.00: failed to IDENTIFY (I/O error, err_mask=0x4) [70756.840742] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4079 task=00000000e8bba149 dev id=18 sas_addr=0x500e004aaaaaaa00 CQ hdr: 0x101b 0x120fef 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 [70756.881620] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed [70756.896277] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4080 task=00000000e8bba149 dev id=18 sas_addr=0x500e004aaaaaaa00 CQ hdr: 0x101b 0x120ff0 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 [70756.937020] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed [70756.951407] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=4081 task=00000000e8bba149 dev id=18 sas_addr=0x500e004aaaaaaa00 CQ hdr: 0x101b 0x120ff1 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 [70756.991856] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed [70757.006124] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: executing internal task failed! [70757.029005] hisi_sas_v3_hw 0000:b4:02.0: ata disk reset failed [70757.042455] hisi_sas_v3_hw 0000:b4:02.0: I_T nexus reset: softreset failed (-5) [70759.240774] sas: --- Exit sas_scsi_recover_host: busy: 0 failed: 0 tries: 1 [70759.250828] sas: sas_probe_sata: for exp-attached device 500e004aaaaaaa00 returned -19 [70759.250845] hisi_sas_v3_hw 0000:b4:02.0: dev[18:5] is gone [70759.264497] sas: broadcast received: 0 [70759.280050] sas: REVALIDATING DOMAIN on port 0, pid:311546 [70759.280189] sas: Expander phy change count has changed [70759.281879] sas: ex 500e004aaaaaaa1f phy0 originated BROADCAST(CHANGE) [70759.281880] sas: ex 500e004aaaaaaa1f phy0 new device attached [70759.281940] sas: ex 500e004aaaaaaa1f phy00:U:A attached: 500e004aaaaaaa00 (stp) [70759.305377] hisi_sas_v3_hw 0000:b4:02.0: dev[19:5] found [70759.478056] sas: done REVALIDATING DOMAIN on port 0, pid:311546, res 0x0 [70759.487508] sas: Enter sas_scsi_recover_host busy: 0 failed: 0 [70759.487522] sas: ata370: end_device-7:0:4: dev error handler [70759.487527] sas: ata371: end_device-7:0:5: dev error handler [70759.487530] sas: ata373: end_device-7:0:1: dev error handler [70759.487539] sas: ata374: end_device-7:0:2: dev error handler [70759.487544] sas: ata375: end_device-7:0:3: dev error handler [70759.487572] sas: ata377: end_device-7:0:0: dev error handler [70761.674270] ata377.00: ATA-11: SAMSUNG MZ7KH960HAJR-00005, HXM7404Q, max UDMA/133 [70761.696856] ata377.00: 1875385008 sectors, multi 16: LBA48 NCQ (depth 32), AA [70761.713233] ata377.00: configured for UDMA/133 [70761.725238] sas: --- Exit sas_scsi_recover_host: busy: 0 failed: 0 tries: 1 Thanks, Xingui ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Revert "scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed" 2025-11-27 7:27 ` yangxingui @ 2025-12-01 12:51 ` John Garry 2025-12-01 13:27 ` Jason Yan 0 siblings, 1 reply; 8+ messages in thread From: John Garry @ 2025-12-01 12:51 UTC (permalink / raw) To: yangxingui, yanaijie, jejb, martin.petersen Cc: linux-scsi, linux-kernel, linuxarm, liyihang9, liuyonglong, kangfenglong On 27/11/2025 07:27, yangxingui wrote: > Hi, John > > I'm glad to receive your reply. > > On 2025/11/27 14:47, John Garry wrote: >> On 27/11/2025 00:59, yangxingui wrote: >>> Kindly ping for upstream. >>> >>> On 2025/10/21 15:34, Xingui Yang wrote: >> >> Your reasons for revert is light on details. >> >>>> This reverts commit ab2068a6fb84751836a84c26ca72b3beb349619d. >>>> >>>> As the disk may fall into an abnormal loop of probe when it fails to >>>> probe >>>> due to physical reasons and cannot be repaired. >> >> So for a faulty disk we get into a indefinite loop, right? > Yes, because a hard reset for SATA disk is executed during the error > handler, a BC event will be received after the disk probe fails, and the > probe will be re-executed on the disk. You need to add these details to the commit log. >> >> What about case where this was helping before? > A temporary fault injected into the disk or link, which can be recovered > after a short time. I'm ok with this if Jason is... > > log before: > [49495.065650] sas: broadcast received: 0 > [49495.065661] sas: REVALIDATING DOMAIN on port 0, pid:318259 > [49495.066190] sas: Expander phy change count has changed > [49495.068368] sas: ex 500e004aaaaaaa1f phy2 originated BROADCAST(CHANGE) > [49495.068369] sas: ex 500e004aaaaaaa1f phy2 new device attached > [49495.068434] sas: ex 500e004aaaaaaa1f phy02:U:9 attached: > 500e004aaaaaaa02 (stp) > [49495.090453] hisi_sas_v3_hw 0000:b4:02.0: dev[698:5] found > [49495.266248] sas: done REVALIDATING DOMAIN on port 0, pid:318259, res 0x0 > [49495.271115] sas: Enter sas_scsi_recover_host busy: 0 failed: 0 > [49495.271129] sas: ata761: end_device-6:3:0: dev error handler > [49495.271133] sas: ata762: end_device-6:3:1: dev error handler > [49495.271136] sas: ata764: end_device-6:3:3: dev error handler > [49495.271170] sas: ata765: end_device-6:3:4: dev error handler > [49495.271171] sas: ata768: end_device-6:3:5: dev error handler > [49495.271173] sas: ata769: end_device-6:3:2: dev error handler > [49497.465030] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4081 task=0000000054417d4d dev id=698 sas_addr=0x500e004aaaaaaa02 > CQ hdr: 0x101b 0x2ba0ff1 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 > [49497.503517] sas: sas_to_ata_err: Saw error 135. What to do? > [49497.503518] sas: sas_ata_task_done: SAS error 87 > [49497.503546] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4082 task=00000000972479c8 dev id=698 sas_addr=0x500e004aaaaaaa02 > CQ hdr: 0x203 0x2ba0ff2 0x0 0x100 Error info: 0x0 0x0 0x0 0x0 > [49497.542451] ata769.00: failed to IDENTIFY (I/O error, err_mask=0x4) > [49502.713074] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4005 task=00000000be2e16ae dev id=698 sas_addr=0x500e004aaaaaaa02 > CQ hdr: 0x101b 0x2ba0fa5 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 > [49502.752805] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed > [49502.767384] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4006 task=00000000be2e16ae dev id=698 sas_addr=0x500e004aaaaaaa02 > CQ hdr: 0x101b 0x2ba0fa6 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 > [49502.807336] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed > [49502.821449] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4007 task=00000000be2e16ae dev id=698 sas_addr=0x500e004aaaaaaa02 > CQ hdr: 0x101b 0x2ba0fa7 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 > [49502.861361] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed > [49502.875664] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: executing > internal task failed! > [49502.898556] hisi_sas_v3_hw 0000:b4:02.0: ata disk reset failed > [49502.912015] hisi_sas_v3_hw 0000:b4:02.0: I_T nexus reset: softreset > failed (-5) > [49505.112967] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4010 task=00000000be2e16ae dev id=698 sas_addr=0x500e004aaaaaaa02 > CQ hdr: 0x203 0x2ba0faa 0x0 0x100 Error info: 0x0 0x0 0x0 0x0 > [49505.153594] ata769.00: failed to IDENTIFY (I/O error, err_mask=0x4) > [49510.137044] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4027 task=00000000d6273fa9 dev id=698 sas_addr=0x500e004aaaaaaa02 > CQ hdr: 0x101b 0x2ba0fbb 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 > [49510.178227] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed > [49510.193284] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4028 task=00000000d6273fa9 dev id=698 sas_addr=0x500e004aaaaaaa02 > CQ hdr: 0x101b 0x2ba0fbc 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 > [49510.234190] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed > [49510.248603] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4029 task=00000000d6273fa9 dev id=698 sas_addr=0x500e004aaaaaaa02 > CQ hdr: 0x101b 0x2ba0fbd 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 > [49510.288968] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed > [49510.303156] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: executing > internal task failed! > [49510.325863] hisi_sas_v3_hw 0000:b4:02.0: ata disk reset failed > [49510.339230] hisi_sas_v3_hw 0000:b4:02.0: I_T nexus reset: softreset > failed (-5) > [49512.536979] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4032 task=00000000d6273fa9 dev id=698 sas_addr=0x500e004aaaaaaa02 > CQ hdr: 0x203 0x2ba0fc0 0x0 0x100 Error info: 0x0 0x0 0x0 0x0 > [49512.577050] ata769.00: failed to IDENTIFY (I/O error, err_mask=0x4) > [49517.561046] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4050 task=0000000070019bd9 dev id=698 sas_addr=0x500e004aaaaaaa02 > CQ hdr: 0x101b 0x2ba0fd2 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 > [49517.601923] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed > [49517.616945] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4051 task=0000000070019bd9 dev id=698 sas_addr=0x500e004aaaaaaa02 > CQ hdr: 0x101b 0x2ba0fd3 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 > [49517.657745] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed > [49517.672097] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4052 task=0000000070019bd9 dev id=698 sas_addr=0x500e004aaaaaaa02 > CQ hdr: 0x101b 0x2ba0fd4 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 > [49517.712567] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed > [49517.726756] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: executing > internal task failed! > [49517.749459] hisi_sas_v3_hw 0000:b4:02.0: ata disk reset failed > [49517.762828] hisi_sas_v3_hw 0000:b4:02.0: I_T nexus reset: softreset > failed (-5) > [49519.960965] sas: --- Exit sas_scsi_recover_host: busy: 0 failed: 0 > tries: 1 > [49519.971018] sas: sas_probe_sata: for exp-attached device > 500e004aaaaaaa02 returned -19 > [49519.971039] hisi_sas_v3_hw 0000:b4:02.0: dev[698:5] is gone > [49519.984864] sas: broadcast received: 0 > [49519.984876] sas: REVALIDATING DOMAIN on port 0, pid:318259 > [49519.985362] sas: Expander phy change count has changed > [49519.987278] sas: ex 500e004aaaaaaa1f phy2 originated BROADCAST(CHANGE) > [49519.987442] sas: ex 500e004aaaaaaa1f phy02:U:A attached: > 500e004aaaaaaa02 (stp) > [49519.987443] sas: ex 500e004aaaaaaa1f phy 0x2 broadcast flutter > [49519.987448] sas: done REVALIDATING DOMAIN on port 0, pid:318259, res 0x0 > > log new after apply the patch: > > [70734.380100] sas: broadcast received: 0 > [70734.380110] sas: REVALIDATING DOMAIN on port 0, pid:311546 > [70734.380431] sas: Expander phy change count has changed > [70734.382191] sas: ex 500e004aaaaaaa1f phy0 originated BROADCAST(CHANGE) > [70734.382193] sas: ex 500e004aaaaaaa1f phy0 new device attached > [70734.382262] sas: ex 500e004aaaaaaa1f phy00:U:9 attached: > 500e004aaaaaaa00 (stp) > [70734.402596] hisi_sas_v3_hw 0000:b4:02.0: dev[18:5] found > [70734.574064] sas: done REVALIDATING DOMAIN on port 0, pid:311546, res 0x0 > [70734.580049] sas: Enter sas_scsi_recover_host busy: 0 failed: 0 > [70734.580064] sas: ata370: end_device-7:0:4: dev error handler > [70734.580066] sas: ata371: end_device-7:0:5: dev error handler > [70734.580071] sas: ata373: end_device-7:0:1: dev error handler > [70734.580075] sas: ata374: end_device-7:0:2: dev error handler > [70734.580076] sas: ata375: end_device-7:0:3: dev error handler > [70734.580077] sas: ata376: end_device-7:0:0: dev error handler > [70736.776755] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4013 task=00000000113fa417 dev id=18 sas_addr=0x500e004aaaaaaa00 CQ > hdr: 0x101b 0x120fad 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 > [70736.813168] sas: sas_to_ata_err: Saw error 135. What to do? > [70736.813169] sas: sas_ata_task_done: SAS error 87 > [70736.813201] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4014 task=0000000037bc53e5 dev id=18 sas_addr=0x500e004aaaaaaa00 CQ > hdr: 0x203 0x120fae 0x0 0x100 Error info: 0x0 0x0 0x0 0x0 > [70736.850261] ata376.00: failed to IDENTIFY (I/O error, err_mask=0x4) > [70741.992742] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4032 task=00000000fe3b3918 dev id=18 sas_addr=0x500e004aaaaaaa00 CQ > hdr: 0x101b 0x120fc0 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 > [70742.030820] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed > [70742.044539] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4033 task=00000000fe3b3918 dev id=18 sas_addr=0x500e004aaaaaaa00 CQ > hdr: 0x101b 0x120fc1 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 > [70742.083611] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed > [70742.097548] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4034 task=00000000fe3b3918 dev id=18 sas_addr=0x500e004aaaaaaa00 CQ > hdr: 0x101b 0x120fc2 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 > [70742.137553] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed > [70742.151829] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: executing > internal task failed! > [70742.174491] hisi_sas_v3_hw 0000:b4:02.0: ata disk reset failed > [70742.187938] hisi_sas_v3_hw 0000:b4:02.0: I_T nexus reset: softreset > failed (-5) > [70744.392769] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4037 task=00000000fe3b3918 dev id=18 sas_addr=0x500e004aaaaaaa00 CQ > hdr: 0x203 0x120fc5 0x0 0x100 Error info: 0x0 0x0 0x0 0x0 > [70744.433129] ata376.00: failed to IDENTIFY (I/O error, err_mask=0x4) > [70749.416741] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4055 task=000000005dbdb66e dev id=18 sas_addr=0x500e004aaaaaaa00 CQ > hdr: 0x101b 0x120fd7 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 > [70749.457819] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed > [70749.472339] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4056 task=000000005dbdb66e dev id=18 sas_addr=0x500e004aaaaaaa00 CQ > hdr: 0x101b 0x120fd8 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 > [70749.513046] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed > [70749.527425] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4057 task=000000005dbdb66e dev id=18 sas_addr=0x500e004aaaaaaa00 CQ > hdr: 0x101b 0x120fd9 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 > [70749.567887] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed > [70749.582146] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: executing > internal task failed! > [70749.604974] hisi_sas_v3_hw 0000:b4:02.0: ata disk reset failed > [70749.618406] hisi_sas_v3_hw 0000:b4:02.0: I_T nexus reset: softreset > failed (-5) > [70751.816753] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4061 task=000000005dbdb66e dev id=18 sas_addr=0x500e004aaaaaaa00 CQ > hdr: 0x203 0x120fdd 0x0 0x100 Error info: 0x0 0x0 0x0 0x0 > [70751.856789] ata376.00: failed to IDENTIFY (I/O error, err_mask=0x4) > [70756.840742] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4079 task=00000000e8bba149 dev id=18 sas_addr=0x500e004aaaaaaa00 CQ > hdr: 0x101b 0x120fef 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 > [70756.881620] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed > [70756.896277] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4080 task=00000000e8bba149 dev id=18 sas_addr=0x500e004aaaaaaa00 CQ > hdr: 0x101b 0x120ff0 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 > [70756.937020] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed > [70756.951407] hisi_sas_v3_hw 0000:b4:02.0: erroneous completion > iptt=4081 task=00000000e8bba149 dev id=18 sas_addr=0x500e004aaaaaaa00 CQ > hdr: 0x101b 0x120ff1 0x0 0x0 Error info: 0x200 0x0 0x0 0x0 > [70756.991856] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: open reject failed > [70757.006124] hisi_sas_v3_hw 0000:b4:02.0: abort tmf: executing > internal task failed! > [70757.029005] hisi_sas_v3_hw 0000:b4:02.0: ata disk reset failed > [70757.042455] hisi_sas_v3_hw 0000:b4:02.0: I_T nexus reset: softreset > failed (-5) > [70759.240774] sas: --- Exit sas_scsi_recover_host: busy: 0 failed: 0 > tries: 1 > [70759.250828] sas: sas_probe_sata: for exp-attached device > 500e004aaaaaaa00 returned -19 > [70759.250845] hisi_sas_v3_hw 0000:b4:02.0: dev[18:5] is gone > [70759.264497] sas: broadcast received: 0 > [70759.280050] sas: REVALIDATING DOMAIN on port 0, pid:311546 > [70759.280189] sas: Expander phy change count has changed > [70759.281879] sas: ex 500e004aaaaaaa1f phy0 originated BROADCAST(CHANGE) > [70759.281880] sas: ex 500e004aaaaaaa1f phy0 new device attached > [70759.281940] sas: ex 500e004aaaaaaa1f phy00:U:A attached: > 500e004aaaaaaa00 (stp) > [70759.305377] hisi_sas_v3_hw 0000:b4:02.0: dev[19:5] found > [70759.478056] sas: done REVALIDATING DOMAIN on port 0, pid:311546, res 0x0 > [70759.487508] sas: Enter sas_scsi_recover_host busy: 0 failed: 0 > [70759.487522] sas: ata370: end_device-7:0:4: dev error handler > [70759.487527] sas: ata371: end_device-7:0:5: dev error handler > [70759.487530] sas: ata373: end_device-7:0:1: dev error handler > [70759.487539] sas: ata374: end_device-7:0:2: dev error handler > [70759.487544] sas: ata375: end_device-7:0:3: dev error handler > [70759.487572] sas: ata377: end_device-7:0:0: dev error handler > [70761.674270] ata377.00: ATA-11: SAMSUNG MZ7KH960HAJR-00005, HXM7404Q, > max UDMA/133 > [70761.696856] ata377.00: 1875385008 sectors, multi 16: LBA48 NCQ (depth > 32), AA > [70761.713233] ata377.00: configured for UDMA/133 > [70761.725238] sas: --- Exit sas_scsi_recover_host: busy: 0 failed: 0 > tries: 1 > > Thanks, > Xingui > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Revert "scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed" 2025-12-01 12:51 ` John Garry @ 2025-12-01 13:27 ` Jason Yan 2025-12-02 7:00 ` yangxingui 0 siblings, 1 reply; 8+ messages in thread From: Jason Yan @ 2025-12-01 13:27 UTC (permalink / raw) To: John Garry, yangxingui, jejb, martin.petersen Cc: linux-scsi, linux-kernel, linuxarm, liyihang9, liuyonglong, kangfenglong 在 2025/12/1 20:51, John Garry 写道: > On 27/11/2025 07:27, yangxingui wrote: >> Hi, John >> >> I'm glad to receive your reply. >> >> On 2025/11/27 14:47, John Garry wrote: >>> On 27/11/2025 00:59, yangxingui wrote: >>>> Kindly ping for upstream. >>>> >>>> On 2025/10/21 15:34, Xingui Yang wrote: >>> >>> Your reasons for revert is light on details. >>> >>>>> This reverts commit ab2068a6fb84751836a84c26ca72b3beb349619d. >>>>> >>>>> As the disk may fall into an abnormal loop of probe when it fails >>>>> to probe >>>>> due to physical reasons and cannot be repaired. >>> >>> So for a faulty disk we get into a indefinite loop, right? >> Yes, because a hard reset for SATA disk is executed during the error >> handler, a BC event will be received after the disk probe fails, and >> the probe will be re-executed on the disk. > > You need to add these details to the commit log. > >>> >>> What about case where this was helping before? >> A temporary fault injected into the disk or link, which can be >> recovered after a short time. > > I'm ok with this if Jason is... I think we can merge this patch first and fix the previous issue later because this issue is more critical. So: Reviewed-by: Jason Yan <yanaijie@huawei.com> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Revert "scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed" 2025-12-01 13:27 ` Jason Yan @ 2025-12-02 7:00 ` yangxingui 0 siblings, 0 replies; 8+ messages in thread From: yangxingui @ 2025-12-02 7:00 UTC (permalink / raw) To: Jason Yan, John Garry, jejb, martin.petersen Cc: linux-scsi, linux-kernel, linuxarm, liyihang9, liuyonglong, kangfenglong On 2025/12/1 21:27, Jason Yan wrote: > 在 2025/12/1 20:51, John Garry 写道: >> On 27/11/2025 07:27, yangxingui wrote: >>> Hi, John >>> >>> I'm glad to receive your reply. >>> >>> On 2025/11/27 14:47, John Garry wrote: >>>> On 27/11/2025 00:59, yangxingui wrote: >>>>> Kindly ping for upstream. >>>>> >>>>> On 2025/10/21 15:34, Xingui Yang wrote: >>>> >>>> Your reasons for revert is light on details. >>>> >>>>>> This reverts commit ab2068a6fb84751836a84c26ca72b3beb349619d. >>>>>> >>>>>> As the disk may fall into an abnormal loop of probe when it fails >>>>>> to probe >>>>>> due to physical reasons and cannot be repaired. >>>> >>>> So for a faulty disk we get into a indefinite loop, right? >>> Yes, because a hard reset for SATA disk is executed during the error >>> handler, a BC event will be received after the disk probe fails, and >>> the probe will be re-executed on the disk. >> >> You need to add these details to the commit log. >> >>>> >>>> What about case where this was helping before? >>> A temporary fault injected into the disk or link, which can be >>> recovered after a short time. >> >> I'm ok with this if Jason is... > > I think we can merge this patch first and fix the previous issue later > because this issue is more critical. So: > > Reviewed-by: Jason Yan <yanaijie@huawei.com> > . Ok, I have resent a new version and update the commit log. Thanks, Xingui . ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Revert "scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed" 2025-10-21 7:34 [PATCH] Revert "scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed" Xingui Yang 2025-11-27 0:59 ` yangxingui @ 2025-11-27 7:21 ` Jason Yan 1 sibling, 0 replies; 8+ messages in thread From: Jason Yan @ 2025-11-27 7:21 UTC (permalink / raw) To: Xingui Yang, john.g.garry, jejb, martin.petersen Cc: linux-scsi, linux-kernel, linuxarm, liyihang9, liuyonglong, kangfenglong 在 2025/10/21 15:34, Xingui Yang 写道: > This reverts commit ab2068a6fb84751836a84c26ca72b3beb349619d. > > As the disk may fall into an abnormal loop of probe when it fails to probe > due to physical reasons and cannot be repaired. > > Signed-off-by: Xingui Yang <yangxingui@huawei.com> > --- > drivers/scsi/libsas/sas_internal.h | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/drivers/scsi/libsas/sas_internal.h b/drivers/scsi/libsas/sas_internal.h > index 03d6ec1eb970..85948963fb97 100644 > --- a/drivers/scsi/libsas/sas_internal.h > +++ b/drivers/scsi/libsas/sas_internal.h > @@ -145,20 +145,6 @@ static inline void sas_fail_probe(struct domain_device *dev, const char *func, i > func, dev->parent ? "exp-attached" : > "direct-attached", > SAS_ADDR(dev->sas_addr), err); > - > - /* > - * If the device probe failed, the expander phy attached address > - * needs to be reset so that the phy will not be treated as flutter > - * in the next revalidation > - */ > - if (dev->parent && !dev_is_expander(dev->dev_type)) { > - struct sas_phy *phy = dev->phy; > - struct domain_device *parent = dev->parent; > - struct ex_phy *ex_phy = &parent->ex_dev.ex_phy[phy->number]; > - > - memset(ex_phy->attached_sas_addr, 0, SAS_ADDR_SIZE); > - } You need to track probe failed times, and if probe failed more than 3 times, stop trying to probe this phy. Jaosn 祝一切顺利 > - > sas_unregister_dev(dev->port, dev); > } > ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-12-02 7:00 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-10-21 7:34 [PATCH] Revert "scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed" Xingui Yang 2025-11-27 0:59 ` yangxingui 2025-11-27 6:47 ` John Garry 2025-11-27 7:27 ` yangxingui 2025-12-01 12:51 ` John Garry 2025-12-01 13:27 ` Jason Yan 2025-12-02 7:00 ` yangxingui 2025-11-27 7:21 ` Jason Yan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox