Linux SCSI subsystem development
 help / color / mirror / Atom feed
* [PATCH] scsi: target: iscsi: fix typos and formatting in lio_target messages
@ 2025-09-10 19:07 Alok Tiwari
  2025-09-11  1:17 ` Mike Christie
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Alok Tiwari @ 2025-09-10 19:07 UTC (permalink / raw)
  To: michael.christie, martin.petersen, linux-scsi, target-devel; +Cc: alok.a.tiwari

Fix several minor issues in lio_target code and messages:
- Correct typo "locatel" -> "locate" in error log.
- Add missing space in pr_debug() message for better readability.
- Fix comment typo: "contig_item" -> "config_item".

These changes improve code clarity and log readability.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
 drivers/target/iscsi/iscsi_target_configfs.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/target/iscsi/iscsi_target_configfs.c b/drivers/target/iscsi/iscsi_target_configfs.c
index 88db94f382bb..efe8cdb20060 100644
--- a/drivers/target/iscsi/iscsi_target_configfs.c
+++ b/drivers/target/iscsi/iscsi_target_configfs.c
@@ -665,7 +665,7 @@ static ssize_t lio_target_nacl_cmdsn_depth_store(struct config_item *item,
 	}
 	acl_ci = &se_nacl->acl_group.cg_item;
 	if (!acl_ci) {
-		pr_err("Unable to locatel acl_ci\n");
+		pr_err("Unable to locate acl_ci\n");
 		return -EINVAL;
 	}
 	tpg_ci = &acl_ci->ci_parent->ci_group->cg_item;
@@ -684,7 +684,7 @@ static ssize_t lio_target_nacl_cmdsn_depth_store(struct config_item *item,
 
 	ret = core_tpg_set_initiator_node_queue_depth(se_nacl, cmdsn_depth);
 
-	pr_debug("LIO_Target_ConfigFS: %s/%s Set CmdSN Window: %u for"
+	pr_debug("LIO_Target_ConfigFS: %s/%s Set CmdSN Window: %u for "
 		"InitiatorName: %s\n", config_item_name(wwn_ci),
 		config_item_name(tpg_ci), cmdsn_depth,
 		config_item_name(acl_ci));
@@ -1131,7 +1131,7 @@ static void lio_target_tiqn_deltpg(struct se_portal_group *se_tpg)
 
 /* End items for lio_target_tiqn_cit */
 
-/* Start LIO-Target TIQN struct contig_item lio_target_cit */
+/* Start LIO-Target TIQN struct config_item lio_target_cit */
 
 static ssize_t lio_target_wwn_lio_version_show(struct config_item *item,
 		char *page)
-- 
2.50.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] scsi: target: iscsi: fix typos and formatting in lio_target messages
  2025-09-10 19:07 [PATCH] scsi: target: iscsi: fix typos and formatting in lio_target messages Alok Tiwari
@ 2025-09-11  1:17 ` Mike Christie
  2025-09-16  1:55 ` Martin K. Petersen
  2025-09-20  2:24 ` Martin K. Petersen
  2 siblings, 0 replies; 4+ messages in thread
From: Mike Christie @ 2025-09-11  1:17 UTC (permalink / raw)
  To: Alok Tiwari, martin.petersen, linux-scsi, target-devel

On 9/10/25 2:07 PM, Alok Tiwari wrote:
> Fix several minor issues in lio_target code and messages:
> - Correct typo "locatel" -> "locate" in error log.
> - Add missing space in pr_debug() message for better readability.
> - Fix comment typo: "contig_item" -> "config_item".
> 
> These changes improve code clarity and log readability.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>


Reviewed-by: Mike Christie <michael.christie@oracle.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] scsi: target: iscsi: fix typos and formatting in lio_target messages
  2025-09-10 19:07 [PATCH] scsi: target: iscsi: fix typos and formatting in lio_target messages Alok Tiwari
  2025-09-11  1:17 ` Mike Christie
@ 2025-09-16  1:55 ` Martin K. Petersen
  2025-09-20  2:24 ` Martin K. Petersen
  2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2025-09-16  1:55 UTC (permalink / raw)
  To: Alok Tiwari; +Cc: michael.christie, martin.petersen, linux-scsi, target-devel


Alok,

> Fix several minor issues in lio_target code and messages:
> - Correct typo "locatel" -> "locate" in error log.
> - Add missing space in pr_debug() message for better readability.
> - Fix comment typo: "contig_item" -> "config_item".

Applied to 6.18/scsi-staging, thanks!

-- 
Martin K. Petersen

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] scsi: target: iscsi: fix typos and formatting in lio_target messages
  2025-09-10 19:07 [PATCH] scsi: target: iscsi: fix typos and formatting in lio_target messages Alok Tiwari
  2025-09-11  1:17 ` Mike Christie
  2025-09-16  1:55 ` Martin K. Petersen
@ 2025-09-20  2:24 ` Martin K. Petersen
  2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2025-09-20  2:24 UTC (permalink / raw)
  To: michael.christie, linux-scsi, target-devel, Alok Tiwari
  Cc: Martin K . Petersen

On Wed, 10 Sep 2025 12:07:20 -0700, Alok Tiwari wrote:

> Fix several minor issues in lio_target code and messages:
> - Correct typo "locatel" -> "locate" in error log.
> - Add missing space in pr_debug() message for better readability.
> - Fix comment typo: "contig_item" -> "config_item".
> 
> These changes improve code clarity and log readability.
> 
> [...]

Applied to 6.18/scsi-queue, thanks!

[1/1] scsi: target: iscsi: fix typos and formatting in lio_target messages
      https://git.kernel.org/mkp/scsi/c/f2d81dd6751a

-- 
Martin K. Petersen

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-09-20  2:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-10 19:07 [PATCH] scsi: target: iscsi: fix typos and formatting in lio_target messages Alok Tiwari
2025-09-11  1:17 ` Mike Christie
2025-09-16  1:55 ` Martin K. Petersen
2025-09-20  2:24 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox