From: Damien Le Moal <dlemoal@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Niklas Cassel <cassel@kernel.org>,
Takashi Sakamoto <o-takashi@sakamocchi.jp>,
Sathya Prakash <sathya.prakash@broadcom.com>,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
Steffen Maier <maier@linux.ibm.com>,
Benjamin Block <bblock@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Hannes Reinecke <hare@suse.com>,
Anil Gurumurthy <anil.gurumurthy@qlogic.com>,
Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>,
Saurav Kashyap <skashyap@marvell.com>,
Javed Hasan <jhasan@marvell.com>,
GR-QLogic-Storage-Upstream@marvell.com,
Oliver Neukum <oliver@neukum.org>, Ali Akcaagac <aliakc@web.de>,
Jamie Lenehan <lenehan@twibble.org>,
Satish Kharat <satishkh@cisco.com>,
Sesidhar Baddela <sebaddel@cisco.com>,
Karan Tilak Kumar <kartilak@cisco.com>,
Yihang Li <liyihang9@huawei.com>,
Don Brace <don.brace@microchip.com>,
Tyrel Datwyler <tyreld@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Brian King <brking@us.ibm.com>,
James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
Kashyap Desai <kashyap.desai@broadcom.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
Shivasharan S <shivasharan.srikanteshwara@broadcom.com>,
Chandrakanth patil <chandrakanth.patil@broadcom.com>,
Nilesh Javali <njavali@marvell.com>,
Manish Rangankar <mrangankar@marvell.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Matthew Wilcox <willy@infradead.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>, Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Geoff Levand <geoff@infradead.org>,
Khalid Aziz <khalid@gonehiking.org>,
John Garry <john.g.garry@oracle.com>,
Soumya Negi <soumya.negi97@gmail.com>,
Peter Wang <peter.wang@mediatek.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Avri Altman <avri.altman@wdc.com>,
Andrew Halaney <ahalaney@redhat.com>,
Bean Huo <beanhuo@micron.com>,
"Bao D. Nguyen" <quic_nguyenb@quicinc.com>
Subject: Re: [PATCH v2 06/11] scsi: Rename .slave_alloc() and .slave_destroy()
Date: Thu, 3 Oct 2024 07:39:43 +0900 [thread overview]
Message-ID: <7f2ae124-e98c-4360-8ab8-654a197751f9@kernel.org> (raw)
In-Reply-To: <20241002203528.4104996-7-bvanassche@acm.org>
On 10/3/24 05:33, Bart Van Assche wrote:
> Rename .slave_alloc() into .sdev_prep() and .slave_destroy() into
"sdev_init" or "sdev_initialize" may be a better name instead of "sdev_prep",
which does not really convey what the call will be preparing for. Also, "prep"
not being fully spelled out may confuse some people.
Thoughts ?
Other than that, looks good to me.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2024-10-02 22:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 20:33 [PATCH v2 00/11] Improve the "slave" function names Bart Van Assche
2024-10-02 20:33 ` [PATCH v2 01/11] scsi: arcmsr: Remove the changelog Bart Van Assche
2024-10-02 22:28 ` Damien Le Moal
2024-10-02 22:39 ` James Bottomley
2024-10-02 23:47 ` Bart Van Assche
2024-10-02 20:33 ` [PATCH v2 02/11] scsi: ips: " Bart Van Assche
2024-10-02 22:28 ` Damien Le Moal
2024-10-02 20:33 ` [PATCH v2 03/11] scsi: lpfc: " Bart Van Assche
2024-10-02 22:29 ` Damien Le Moal
2024-10-02 20:33 ` [PATCH v2 04/11] scsi: ncr53c8xx: " Bart Van Assche
2024-10-02 22:29 ` Damien Le Moal
2024-10-02 20:33 ` [PATCH v2 05/11] scsi: sym53c8xx: " Bart Van Assche
2024-10-02 22:30 ` Damien Le Moal
2024-10-02 20:33 ` [PATCH v2 06/11] scsi: Rename .slave_alloc() and .slave_destroy() Bart Van Assche
2024-10-02 22:39 ` Damien Le Moal [this message]
2024-10-03 21:08 ` Bart Van Assche
2024-10-02 20:33 ` [PATCH v2 07/11] scsi: core: Rename .slave_alloc() and .slave_destroy() in the documentation Bart Van Assche
2024-10-02 20:34 ` [PATCH v2 08/11] scsi: Rename .device_configure() into .sdev_configure() Bart Van Assche
2024-10-02 22:35 ` Damien Le Moal
2024-10-02 20:34 ` [PATCH v2 09/11] scsi: Convert SCSI drivers to .sdev_configure() Bart Van Assche
2024-10-02 22:37 ` Damien Le Moal
2024-10-02 20:34 ` [PATCH v2 10/11] scsi: core: Remove the .slave_configure() method Bart Van Assche
2024-10-02 22:38 ` Damien Le Moal
2024-10-02 20:34 ` [PATCH v2 11/11] scsi: core: Update .slave_configure() references in the documentation Bart Van Assche
2024-10-02 22:38 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f2ae124-e98c-4360-8ab8-654a197751f9@kernel.org \
--to=dlemoal@kernel.org \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agordeev@linux.ibm.com \
--cc=ahalaney@redhat.com \
--cc=aliakc@web.de \
--cc=anil.gurumurthy@qlogic.com \
--cc=avri.altman@wdc.com \
--cc=bblock@linux.ibm.com \
--cc=beanhuo@micron.com \
--cc=brking@us.ibm.com \
--cc=bvanassche@acm.org \
--cc=cassel@kernel.org \
--cc=chandrakanth.patil@broadcom.com \
--cc=decui@microsoft.com \
--cc=dick.kennedy@broadcom.com \
--cc=don.brace@microchip.com \
--cc=geoff@infradead.org \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=hare@suse.com \
--cc=hca@linux.ibm.com \
--cc=james.smart@broadcom.com \
--cc=jasowang@redhat.com \
--cc=jgross@suse.com \
--cc=jhasan@marvell.com \
--cc=john.g.garry@oracle.com \
--cc=kartilak@cisco.com \
--cc=kashyap.desai@broadcom.com \
--cc=khalid@gonehiking.org \
--cc=kys@microsoft.com \
--cc=lenehan@twibble.org \
--cc=linux-scsi@vger.kernel.org \
--cc=liyihang9@huawei.com \
--cc=maier@linux.ibm.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=mrangankar@marvell.com \
--cc=mst@redhat.com \
--cc=njavali@marvell.com \
--cc=o-takashi@sakamocchi.jp \
--cc=oliver@neukum.org \
--cc=peter.wang@mediatek.com \
--cc=quic_nguyenb@quicinc.com \
--cc=sathya.prakash@broadcom.com \
--cc=satishkh@cisco.com \
--cc=sebaddel@cisco.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=skashyap@marvell.com \
--cc=soumya.negi97@gmail.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=sstabellini@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=sudarsana.kalluru@qlogic.com \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=sumit.saxena@broadcom.com \
--cc=tyreld@linux.ibm.com \
--cc=wei.liu@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox