From: Bart Van Assche <bvanassche@acm.org>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 07/14] sd: implement ->free_disk to simplify refcounting
Date: Tue, 8 Mar 2022 20:39:34 -0800 [thread overview]
Message-ID: <809e3df8-60e7-131c-955f-c72ae6ededa8@acm.org> (raw)
In-Reply-To: <20220308055200.735835-8-hch@lst.de>
On 3/7/22 21:51, Christoph Hellwig wrote:
> Implement the ->free_disk method to to put struct scsi_disk when the last
> gendisk reference count goes away. This removes the need to clear
> ->private_data and thus freeze the queue on unbind.
Nice work!
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2022-03-09 4:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 5:51 move more work to disk_release v4 Christoph Hellwig
2022-03-08 5:51 ` [PATCH 01/14] blk-mq: do not include passthrough requests in I/O accounting Christoph Hellwig
2022-03-08 5:51 ` [PATCH 02/14] blk-mq: handle already freed tags gracefully in blk_mq_free_rqs Christoph Hellwig
2022-03-08 5:51 ` [PATCH 03/14] scsi: don't use disk->private_data to find the scsi_driver Christoph Hellwig
2022-03-08 5:51 ` [PATCH 04/14] sd: rename the scsi_disk.dev field Christoph Hellwig
2022-03-08 5:51 ` [PATCH 05/14] sd: call sd_zbc_release_disk before releasing the scsi_device reference Christoph Hellwig
2022-03-08 5:51 ` [PATCH 06/14] sd: delay calling free_opal_dev Christoph Hellwig
2022-03-08 5:51 ` [PATCH 07/14] sd: implement ->free_disk to simplify refcounting Christoph Hellwig
2022-03-09 4:39 ` Bart Van Assche [this message]
2022-03-08 5:51 ` [PATCH 08/14] sr: " Christoph Hellwig
2022-03-08 5:51 ` [PATCH 09/14] block: move blkcg initialization/destroy into disk allocation/release handler Christoph Hellwig
2022-03-08 5:51 ` [PATCH 10/14] block: don't remove hctx debugfs dir from blk_mq_exit_queue Christoph Hellwig
2022-03-08 5:51 ` [PATCH 11/14] block: move q_usage_counter release into blk_queue_release Christoph Hellwig
2022-03-08 5:51 ` [PATCH 12/14] block: move blk_exit_queue into disk_release Christoph Hellwig
2022-03-08 5:51 ` [PATCH 13/14] block: do more work in elevator_exit Christoph Hellwig
2022-03-08 5:52 ` [PATCH 14/14] block: move rq_qos_exit() into disk_release() Christoph Hellwig
2022-03-09 0:58 ` move more work to disk_release v4 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=809e3df8-60e7-131c-955f-c72ae6ededa8@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox