From: Douglas Gilbert <dgilbert@interlog.com>
To: Bart Van Assche <bvanassche@acm.org>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
Adrian Hunter <adrian.hunter@intel.com>,
Avri Altman <avri.altman@wdc.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH v2 7/8] scsi_debug: Support configuring the maximum segment size
Date: Fri, 25 Nov 2022 12:34:36 -0500 [thread overview]
Message-ID: <8a3a5d53-d1e1-0c95-4aea-923c46ac4e32@interlog.com> (raw)
In-Reply-To: <20221123205740.463185-8-bvanassche@acm.org>
On 2022-11-23 15:57, Bart Van Assche wrote:
> Add a kernel module parameter for configuring the maximum segment size.
> This patch enables testing SCSI support for segments smaller than the
> page size.
>
> Cc: Doug Gilbert <dgilbert@interlog.com>
> Cc: Martin K. Petersen <martin.petersen@oracle.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/scsi/scsi_debug.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
> index bebda917b138..ea8f762c55c3 100644
> --- a/drivers/scsi/scsi_debug.c
> +++ b/drivers/scsi/scsi_debug.c
> @@ -770,6 +770,7 @@ static int sdebug_sector_size = DEF_SECTOR_SIZE;
> static int sdeb_tur_ms_to_ready = DEF_TUR_MS_TO_READY;
> static int sdebug_virtual_gb = DEF_VIRTUAL_GB;
> static int sdebug_vpd_use_hostno = DEF_VPD_USE_HOSTNO;
> +static unsigned int sdebug_max_segment_size = -1U > static unsigned int sdebug_lbpu = DEF_LBPU;
> static unsigned int sdebug_lbpws = DEF_LBPWS;
> static unsigned int sdebug_lbpws10 = DEF_LBPWS10;
> @@ -5851,6 +5852,7 @@ module_param_named(ndelay, sdebug_ndelay, int, S_IRUGO | S_IWUSR);
> module_param_named(no_lun_0, sdebug_no_lun_0, int, S_IRUGO | S_IWUSR);
> module_param_named(no_rwlock, sdebug_no_rwlock, bool, S_IRUGO | S_IWUSR);
> module_param_named(no_uld, sdebug_no_uld, int, S_IRUGO);
> +module_param_named(max_segment_size, sdebug_max_segment_size, uint, S_IRUGO);
Could you place the above line in alphabetical order.
> module_param_named(num_parts, sdebug_num_parts, int, S_IRUGO);
> module_param_named(num_tgts, sdebug_num_tgts, int, S_IRUGO | S_IWUSR);
> module_param_named(opt_blks, sdebug_opt_blks, int, S_IRUGO);
> @@ -7815,6 +7817,7 @@ static int sdebug_driver_probe(struct device *dev)
>
> sdebug_driver_template.can_queue = sdebug_max_queue;
> sdebug_driver_template.cmd_per_lun = sdebug_max_queue;
> + sdebug_driver_template.max_segment_size = sdebug_max_segment_size;
> if (!sdebug_clustering)
> sdebug_driver_template.dma_boundary = PAGE_SIZE - 1;
>
And could you add a
MODULE_PARM_DESC(max_segment_size, "<1 line description>");
entry as well (also in alphabetical order).
Other than that:
Ack-ed by: Douglas Gilbert <dgilbert@interlog.com>
next prev parent reply other threads:[~2022-11-25 17:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 20:57 [PATCH v2 0/8] Add support for segments smaller than one page Bart Van Assche
2022-11-23 20:57 ` [PATCH v2 1/8] block: Introduce CONFIG_BLK_SUB_PAGE_SEGMENTS and QUEUE_FLAG_SUB_PAGE_SEGMENTS Bart Van Assche
2022-11-23 20:57 ` [PATCH v2 2/8] block: Support configuring limits below the page size Bart Van Assche
2022-11-23 20:57 ` [PATCH v2 3/8] block: Support submitting passthrough requests with small segments Bart Van Assche
2022-11-23 20:57 ` [PATCH v2 4/8] block: Add support for filesystem requests and " Bart Van Assche
2022-11-23 20:57 ` [PATCH v2 5/8] block: Add support for small segments in blk_rq_map_user_iov() Bart Van Assche
2022-11-23 20:57 ` [PATCH v2 6/8] scsi: core: Set the SUB_PAGE_SEGMENTS request queue flag Bart Van Assche
2022-11-23 20:57 ` [PATCH v2 7/8] scsi_debug: Support configuring the maximum segment size Bart Van Assche
2022-11-25 17:34 ` Douglas Gilbert [this message]
2022-11-30 22:30 ` Bart Van Assche
2022-11-23 20:57 ` [PATCH v2 8/8] null_blk: " Bart Van Assche
2022-11-24 1:40 ` Damien Le Moal
2022-11-30 22:29 ` Bart Van Assche
2022-12-01 0:39 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a3a5d53-d1e1-0c95-4aea-923c46ac4e32@interlog.com \
--to=dgilbert@interlog.com \
--cc=adrian.hunter@intel.com \
--cc=avri.altman@wdc.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox