* [PATCH] ufs: switch WriteBooster missing free space message as warn_once
@ 2026-06-18 7:52 Neil Armstrong
2026-07-06 14:36 ` Bart Van Assche
0 siblings, 1 reply; 2+ messages in thread
From: Neil Armstrong @ 2026-06-18 7:52 UTC (permalink / raw)
To: Alim Akhtar, Avri Altman, Bart Van Assche, James E.J. Bottomley,
Martin K. Petersen
Cc: linux-scsi, linux-kernel, Neil Armstrong
Once the UFS WriteBooster fails to allocate memory, the situation
will stay until fstrim or equivalent is ran.
Mark is as a warning since it impacts the performance but only
print it once for the lifetime of the kernel since it's not fatal.
Otherwise it will be printed each time the device is resumed:
[ 31.666880] ufshcd-qcom 1d84000.ufshc: dCurWBBuf: 0 WB disabled until free-space is available
[ 52.655594] ufshcd-qcom 1d84000.ufshc: dCurWBBuf: 0 WB disabled until free-space is available
[ 62.890469] ufshcd-qcom 1d84000.ufshc: dCurWBBuf: 0 WB disabled until free-space is available
...
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
drivers/ufs/core/ufshcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index c3f08957d179..579bf604e6f0 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -6367,8 +6367,8 @@ static bool ufshcd_wb_curr_buff_threshold_check(struct ufs_hba *hba,
}
if (!cur_buf) {
- dev_info(hba->dev, "dCurWBBuf: %d WB disabled until free-space is available\n",
- cur_buf);
+ dev_warn_once(hba->dev, "dCurWBBuf: %d WB disabled until free-space is available\n",
+ cur_buf);
return false;
}
/* Let it continue to flush when available buffer exceeds threshold */
---
base-commit: 8cd9520d35a6c38db6567e97dd93b1f11f185dc6
change-id: 20260618-topic-ufs-wb-empty-warn-4c1129fc0346
Best regards,
--
Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ufs: switch WriteBooster missing free space message as warn_once
2026-06-18 7:52 [PATCH] ufs: switch WriteBooster missing free space message as warn_once Neil Armstrong
@ 2026-07-06 14:36 ` Bart Van Assche
0 siblings, 0 replies; 2+ messages in thread
From: Bart Van Assche @ 2026-07-06 14:36 UTC (permalink / raw)
To: Neil Armstrong, Alim Akhtar, Avri Altman, James E.J. Bottomley,
Martin K. Petersen
Cc: linux-scsi, linux-kernel
On 6/18/26 12:52 AM, Neil Armstrong wrote:
> Once the UFS WriteBooster fails to allocate memory, the situation
> will stay until fstrim or equivalent is ran.
>
> Mark is as a warning since it impacts the performance but only
> print it once for the lifetime of the kernel since it's not fatal.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-06 14:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-18 7:52 [PATCH] ufs: switch WriteBooster missing free space message as warn_once Neil Armstrong
2026-07-06 14:36 ` Bart Van Assche
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox