* [PATCH] scsi: pm: Drop unneeded call to pm_runtime_mark_last_busy()
@ 2025-10-27 15:20 Nuno Sá via B4 Relay
2025-10-27 16:37 ` Bart Van Assche
0 siblings, 1 reply; 3+ messages in thread
From: Nuno Sá via B4 Relay @ 2025-10-27 15:20 UTC (permalink / raw)
To: linux-scsi; +Cc: James E.J. Bottomley, Martin K. Petersen
From: Nuno Sá <nuno.sa@analog.com>
There's no need to explicitly call pm_runtime_mark_last_busy() since
pm_runtime_autosuspend() is now doing it.
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
drivers/scsi/scsi_pm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/scsi_pm.c b/drivers/scsi/scsi_pm.c
index d581613d87c7..2652fecbfe47 100644
--- a/drivers/scsi/scsi_pm.c
+++ b/drivers/scsi/scsi_pm.c
@@ -205,7 +205,6 @@ static int scsi_runtime_idle(struct device *dev)
/* Insert hooks here for targets, hosts, and transport classes */
if (scsi_is_sdev_device(dev)) {
- pm_runtime_mark_last_busy(dev);
pm_runtime_autosuspend(dev);
return -EBUSY;
}
---
base-commit: 8fec172c82c2b5f6f8e47ab837c1dc91ee3d1b87
change-id: 20251027-scsi-pm-improv-71477eb109c2
--
Thanks!
- Nuno Sá
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: pm: Drop unneeded call to pm_runtime_mark_last_busy()
2025-10-27 15:20 [PATCH] scsi: pm: Drop unneeded call to pm_runtime_mark_last_busy() Nuno Sá via B4 Relay
@ 2025-10-27 16:37 ` Bart Van Assche
2025-10-28 9:27 ` Nuno Sá
0 siblings, 1 reply; 3+ messages in thread
From: Bart Van Assche @ 2025-10-27 16:37 UTC (permalink / raw)
To: nuno.sa, linux-scsi; +Cc: James E.J. Bottomley, Martin K. Petersen
On 10/27/25 8:20 AM, Nuno Sá via B4 Relay wrote:
> There's no need to explicitly call pm_runtime_mark_last_busy() since
> pm_runtime_autosuspend() is now doing it.
"now"? Please mention the commit that introduced this behavior change in
the description of your patch.
Thanks,
Bart.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: pm: Drop unneeded call to pm_runtime_mark_last_busy()
2025-10-27 16:37 ` Bart Van Assche
@ 2025-10-28 9:27 ` Nuno Sá
0 siblings, 0 replies; 3+ messages in thread
From: Nuno Sá @ 2025-10-28 9:27 UTC (permalink / raw)
To: Bart Van Assche, nuno.sa, linux-scsi
Cc: James E.J. Bottomley, Martin K. Petersen
On Mon, 2025-10-27 at 09:37 -0700, Bart Van Assche wrote:
> On 10/27/25 8:20 AM, Nuno Sá via B4 Relay wrote:
> > There's no need to explicitly call pm_runtime_mark_last_busy() since
> > pm_runtime_autosuspend() is now doing it.
>
> "now"? Please mention the commit that introduced this behavior change in
> the description of your patch.
Yes, commit 08071e64cb64 ("PM: runtime: Mark last busy stamp in
pm_runtime_autosuspend()") introduced it. I'll put it in the commit message.
- Nuno Sá
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-28 9:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-27 15:20 [PATCH] scsi: pm: Drop unneeded call to pm_runtime_mark_last_busy() Nuno Sá via B4 Relay
2025-10-27 16:37 ` Bart Van Assche
2025-10-28 9:27 ` Nuno Sá
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox