From: Bart Van Assche <bvanassche@acm.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Avri Altman <avri.altman@wdc.com>, Bean Huo <beanhuo@micron.com>,
Asutosh Das <quic_asutoshd@quicinc.com>,
"Bao D. Nguyen" <quic_nguyenb@quicinc.com>,
Arthur Simchaev <Arthur.Simchaev@wdc.com>,
Can Guo <quic_cang@quicinc.com>,
llvm@lists.linux.dev
Subject: Re: [PATCH] scsi: ufs: Fix the build for gcc 9 and before
Date: Tue, 1 Aug 2023 16:23:22 -0700 [thread overview]
Message-ID: <8f7404dd-dab7-e599-31ff-3204b6a11943@acm.org> (raw)
In-Reply-To: <20230801215240.GA534984@dev-arch.thelio-3990X>
On 8/1/23 14:52, Nathan Chancellor wrote:
> On Tue, Aug 01, 2023 at 01:13:23PM -0700, Bart Van Assche wrote:
>> static void ufshcd_check_header_layout(void)
>> {
>> +#if defined(__GNUC__) && __GNUC__ -0 < 10
>
> clang defines __GNUC__ and it does not sound like it is impacted by this
> issue? I just built with LLVM 11 through 17 and did not see it. Can this
> be made more specific?
>
> Also, can we use IS_ENABLED() and not rely on the preprocessor? This
> appears to work for me.
>
> if (IS_ENABLED(CONFIG_CC_IS_GCC) && CONFIG_GCC_VERSION < 100000)
> return;
Thanks for the feedback. A new version of this patch has been posted.
Bart.
prev parent reply other threads:[~2023-08-01 23:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 20:13 [PATCH] scsi: ufs: Fix the build for gcc 9 and before Bart Van Assche
2023-08-01 21:52 ` Nathan Chancellor
2023-08-01 23:23 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f7404dd-dab7-e599-31ff-3204b6a11943@acm.org \
--to=bvanassche@acm.org \
--cc=Arthur.Simchaev@wdc.com \
--cc=arnd@arndb.de \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.petersen@oracle.com \
--cc=naresh.kamboju@linaro.org \
--cc=nathan@kernel.org \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox