Re: [PATCH] scsi: ufs: core: Fix stale comment in ufshcd_mcq_config_nr_queues()

[Bart Van Assche <bvanassche@acm.org>]

On 10/15/26 11:44 PM, Shawn Lin wrote:
> diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
> index df293b6..15401e1 100644
> --- a/drivers/ufs/core/ufs-mcq.c
> +++ b/drivers/ufs/core/ufs-mcq.c
> @@ -184,7 +184,7 @@ static int ufshcd_mcq_config_nr_queues(struct ufs_hba *hba)
>   
>   	/*
>   	 * Device should support at least one I/O queue to handle device
> -	 * commands via hba->dev_cmd_queue.
> +	 * commands, which cannot be handled by a poll queue.
>   	 */
>   	if (hba_maxq == poll_queues) {
>   		dev_err(hba->dev, "At least one non-poll queue required\n");

A few comments:
- "Device" in the existing comment is inaccurate since hba_maxq is a
   host controller capability rather than a UFS device property.
- At least one non-poll (HCTX_TYPE_DEFAULT) queue is required not only
   for UFS device management commands, but also for all non-polled SCSI
   commands. How about updating the comment to:
	/*
	 * At least one non-poll (HCTX_TYPE_DEFAULT) queue is required for
	 * non-polled SCSI commands and UFS device management commands.
	 */
- Please drop the Fixes: tag since this patch only updates a comment.

Thanks,

Bart.