[PATCH] scsi: ufs: core: Fix stale comment in ufshcd_mcq_config_nr_queues()

[PATCH] scsi: ufs: core: Fix stale comment in ufshcd_mcq_config_nr_queues()

[Shawn Lin]

The comment refers to "hba->dev_cmd_queue", but struct ufs_hba no longer
has such a member (it was removed when the dedicated hwq for device
commands was dropped). Device commands still need a non-poll I/O queue to
be handled, so drop the stale member reference and just say so.

Fixes: 08b12cda6c44 ("scsi: ufs: core: Switch to scsi_get_internal_cmd()")
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---

 drivers/ufs/core/ufs-mcq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
index df293b6..15401e1 100644
--- a/drivers/ufs/core/ufs-mcq.c
+++ b/drivers/ufs/core/ufs-mcq.c
@@ -184,7 +184,7 @@ static int ufshcd_mcq_config_nr_queues(struct ufs_hba *hba)
 
 	/*
 	 * Device should support at least one I/O queue to handle device
-	 * commands via hba->dev_cmd_queue.
+	 * commands, which cannot be handled by a poll queue.
 	 */
 	if (hba_maxq == poll_queues) {
 		dev_err(hba->dev, "At least one non-poll queue required\n");
-- 
2.7.4

Re: [PATCH] scsi: ufs: core: Fix stale comment in ufshcd_mcq_config_nr_queues()

[Stanley Jhu]

Reviewed-by: Stanley Jhu <stanleyjhu@google.com>

Re: [PATCH] scsi: ufs: core: Fix stale comment in ufshcd_mcq_config_nr_queues()

[Bart Van Assche]

On 10/15/26 11:44 PM, Shawn Lin wrote:
> diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
> index df293b6..15401e1 100644
> --- a/drivers/ufs/core/ufs-mcq.c
> +++ b/drivers/ufs/core/ufs-mcq.c
> @@ -184,7 +184,7 @@ static int ufshcd_mcq_config_nr_queues(struct ufs_hba *hba)
>   
>   	/*
>   	 * Device should support at least one I/O queue to handle device
> -	 * commands via hba->dev_cmd_queue.
> +	 * commands, which cannot be handled by a poll queue.
>   	 */
>   	if (hba_maxq == poll_queues) {
>   		dev_err(hba->dev, "At least one non-poll queue required\n");

A few comments:
- "Device" in the existing comment is inaccurate since hba_maxq is a
   host controller capability rather than a UFS device property.
- At least one non-poll (HCTX_TYPE_DEFAULT) queue is required not only
   for UFS device management commands, but also for all non-polled SCSI
   commands. How about updating the comment to:
	/*
	 * At least one non-poll (HCTX_TYPE_DEFAULT) queue is required for
	 * non-polled SCSI commands and UFS device management commands.
	 */
- Please drop the Fixes: tag since this patch only updates a comment.

Thanks,

Bart.

Re: [PATCH] scsi: ufs: core: Fix stale comment in ufshcd_mcq_config_nr_queues()

[Shawn Lin]

在 2026/10/17 星期六 2:18, Bart Van Assche 写道:
> On 10/15/26 11:44 PM, Shawn Lin wrote:
>> diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
>> index df293b6..15401e1 100644
>> --- a/drivers/ufs/core/ufs-mcq.c
>> +++ b/drivers/ufs/core/ufs-mcq.c
>> @@ -184,7 +184,7 @@ static int ufshcd_mcq_config_nr_queues(struct 
>> ufs_hba *hba)
>>       /*
>>        * Device should support at least one I/O queue to handle device
>> -     * commands via hba->dev_cmd_queue.
>> +     * commands, which cannot be handled by a poll queue.
>>        */
>>       if (hba_maxq == poll_queues) {
>>           dev_err(hba->dev, "At least one non-poll queue required\n");
> 
> A few comments:
> - "Device" in the existing comment is inaccurate since hba_maxq is a
>    host controller capability rather than a UFS device property.
> - At least one non-poll (HCTX_TYPE_DEFAULT) queue is required not only
>    for UFS device management commands, but also for all non-polled SCSI
>    commands. How about updating the comment to:
>      /*
>       * At least one non-poll (HCTX_TYPE_DEFAULT) queue is required for
>       * non-polled SCSI commands and UFS device management commands.
>       */
> - Please drop the Fixes: tag since this patch only updates a comment.
> 

Sure, will do.

> Thanks,
> 
> Bart.
>