From: Bart Van Assche <bvanassche@acm.org>
To: "Ewan D. Milne" <emilne@redhat.com>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2] scsi: avoid repetitive logging of device offline messages
Date: Wed, 11 Mar 2020 19:21:17 -0700 [thread overview]
Message-ID: <99454400-cc4c-3431-ed48-e62bf39bba76@acm.org> (raw)
In-Reply-To: <20200311143930.20674-1-emilne@redhat.com>
On 2020-03-11 07:39, Ewan D. Milne wrote:
> Large queues of I/O to offline devices that are eventually
> submitted when devices are unblocked result in a many repeated
> "rejecting I/O to offline device" messages. These messages
> can fill up the dmesg buffer in crash dumps so no useful
> prior messages remain. In addition, if a serial console
> is used, the flood of messages can cause a hard lockup in
> the console code.
>
> Introduce a flag indicating the message has already been logged
> for the device, and reset the flag when scsi_device_set_state()
> changes the device state.
>
> v2:
> Changed flag type from bitfield to bool by request
Thanks!
Reviewed-by: Bart van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2020-03-12 2:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 14:39 [PATCH v2] scsi: avoid repetitive logging of device offline messages Ewan D. Milne
2020-03-12 2:21 ` Bart Van Assche [this message]
2020-03-12 3:09 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99454400-cc4c-3431-ed48-e62bf39bba76@acm.org \
--to=bvanassche@acm.org \
--cc=emilne@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox