From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Ewan D. Milne" <emilne@redhat.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2] scsi: avoid repetitive logging of device offline messages
Date: Wed, 11 Mar 2020 23:09:50 -0400 [thread overview]
Message-ID: <yq1wo7q9sld.fsf@oracle.com> (raw)
In-Reply-To: <20200311143930.20674-1-emilne@redhat.com> (Ewan D. Milne's message of "Wed, 11 Mar 2020 10:39:30 -0400")
Ewan,
> Large queues of I/O to offline devices that are eventually submitted
> when devices are unblocked result in a many repeated "rejecting I/O to
> offline device" messages. These messages can fill up the dmesg buffer
> in crash dumps so no useful prior messages remain. In addition, if a
> serial console is used, the flood of messages can cause a hard lockup
> in the console code.
>
> Introduce a flag indicating the message has already been logged for
> the device, and reset the flag when scsi_device_set_state() changes
> the device state.
Applied to 5.7/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2020-03-12 3:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 14:39 [PATCH v2] scsi: avoid repetitive logging of device offline messages Ewan D. Milne
2020-03-12 2:21 ` Bart Van Assche
2020-03-12 3:09 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1wo7q9sld.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=emilne@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox