Re: [PATCH 01/17] lpfc: Initialize status local variable in lpfc_sli4_repost_sgl_list

[Himanshu Madhani <himanshu.madhani@oracle.com>]

On 1/30/24 16:35, Justin Tee wrote:
> A static code analyzer tool indicates that the local variable called status
> in the lpfc_sli4_repost_sgl_list routine could be used to print garbage
> uninitialized values in the routine's log message.
> 
> Fix by initializing to zero.
> 
> Signed-off-by: Justin Tee <justin.tee@broadcom.com>
> ---
>   drivers/scsi/lpfc/lpfc_sli.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
> index 706985358c6a..c7a2f565e2c2 100644
> --- a/drivers/scsi/lpfc/lpfc_sli.c
> +++ b/drivers/scsi/lpfc/lpfc_sli.c
> @@ -7582,7 +7582,7 @@ lpfc_sli4_repost_sgl_list(struct lpfc_hba *phba,
>   	struct lpfc_sglq *sglq_entry = NULL;
>   	struct lpfc_sglq *sglq_entry_next = NULL;
>   	struct lpfc_sglq *sglq_entry_first = NULL;
> -	int status, total_cnt;
> +	int status = 0, total_cnt;
>   	int post_cnt = 0, num_posted = 0, block_cnt = 0;
>   	int last_xritag = NO_XRI;
>   	LIST_HEAD(prep_sgl_list);

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

-- 
Himanshu Madhani                                Oracle Linux Engineering