Re: [PATCH 03/17] lpfc: Use sg_dma_len API to get struct scatterlist's length

[Himanshu Madhani <himanshu.madhani@oracle.com>]

On 1/30/24 16:35, Justin Tee wrote:
> The sg_dma_len API should be used to retrieve a scatterlist's length
> instead of directly accessing scatterlist->length.
> 
> Signed-off-by: Justin Tee <justin.tee@broadcom.com>
> ---
>   drivers/scsi/lpfc/lpfc_scsi.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
> index d26941b131fd..07e941da8a16 100644
> --- a/drivers/scsi/lpfc/lpfc_scsi.c
> +++ b/drivers/scsi/lpfc/lpfc_scsi.c
> @@ -2728,14 +2728,14 @@ lpfc_calc_bg_err(struct lpfc_hba *phba, struct lpfc_io_buf *lpfc_cmd)
>   		sgde = scsi_sglist(cmd);
>   		blksize = scsi_prot_interval(cmd);
>   		data_src = (uint8_t *)sg_virt(sgde);
> -		data_len = sgde->length;
> +		data_len = sg_dma_len(sgde);
>   		if ((data_len & (blksize - 1)) == 0)
>   			chk_guard = 1;
>   
>   		src = (struct scsi_dif_tuple *)sg_virt(sgpe);
>   		start_ref_tag = scsi_prot_ref_tag(cmd);
>   		start_app_tag = src->app_tag;
> -		len = sgpe->length;
> +		len = sg_dma_len(sgpe);
>   		while (src && protsegcnt) {
>   			while (len) {
>   
> @@ -2800,7 +2800,7 @@ lpfc_calc_bg_err(struct lpfc_hba *phba, struct lpfc_io_buf *lpfc_cmd)
>   						goto out;
>   
>   					data_src = (uint8_t *)sg_virt(sgde);
> -					data_len = sgde->length;
> +					data_len = sg_dma_len(sgde);
>   					if ((data_len & (blksize - 1)) == 0)
>   						chk_guard = 1;
>   				}
> @@ -2810,7 +2810,7 @@ lpfc_calc_bg_err(struct lpfc_hba *phba, struct lpfc_io_buf *lpfc_cmd)
>   			sgpe = sg_next(sgpe);
>   			if (sgpe) {
>   				src = (struct scsi_dif_tuple *)sg_virt(sgpe);
> -				len = sgpe->length;
> +				len = sg_dma_len(sgpe);
>   			} else {
>   				src = NULL;
>   			}

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

-- 
Himanshu Madhani                                Oracle Linux Engineering