From: Damien Le Moal <dlemoal@kernel.org>
To: John Garry <john.g.garry@oracle.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: Correct sysfs attributes access rights
Date: Mon, 28 Jul 2025 18:52:25 +0900 [thread overview]
Message-ID: <9b997705-c758-44bc-bb7c-60039304cc03@kernel.org> (raw)
In-Reply-To: <d3d6659e-dfff-4f4f-ad3b-afe053fe736d@oracle.com>
On 7/28/25 6:40 PM, John Garry wrote:
> On 28/07/2025 05:17, Damien Le Moal wrote:
>> The scsi sysfs attributes "supported_mode" and "active_mode" do not
>> define a store method and thus cannot be modified. Correct the
>> DEVICE_ATTR() call for these two attributes to not include S_IWUSR to
>> allow write access as they are read-only.
>>
>> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
>
> Reviewed-by: John Garry <john.g.garry@oracle.com>
>
> Note that class_attr_store() returns -EIO for no store method. Does the same
> happen after this change?
The regular Permission Denied (-EPERM) is returned.
Do you think that is a problem ?
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-07-28 9:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 4:17 [PATCH] scsi: Correct sysfs attributes access rights Damien Le Moal
2025-07-28 9:40 ` John Garry
2025-07-28 9:52 ` Damien Le Moal [this message]
2025-07-28 9:57 ` John Garry
2025-07-28 10:46 ` Johannes Thumshirn
2025-07-29 2:33 ` Martin K. Petersen
2025-08-06 2:39 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b997705-c758-44bc-bb7c-60039304cc03@kernel.org \
--to=dlemoal@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox