From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: Correct sysfs attributes access rights
Date: Mon, 28 Jul 2025 22:33:18 -0400 [thread overview]
Message-ID: <yq1seifn2u8.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20250728041700.76660-1-dlemoal@kernel.org> (Damien Le Moal's message of "Mon, 28 Jul 2025 13:17:00 +0900")
Damien,
> The scsi sysfs attributes "supported_mode" and "active_mode" do not
> define a store method and thus cannot be modified. Correct the
> DEVICE_ATTR() call for these two attributes to not include S_IWUSR to
> allow write access as they are read-only.
Applied to 6.17/scsi-staging, thanks!
--
Martin K. Petersen
next prev parent reply other threads:[~2025-07-29 2:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 4:17 [PATCH] scsi: Correct sysfs attributes access rights Damien Le Moal
2025-07-28 9:40 ` John Garry
2025-07-28 9:52 ` Damien Le Moal
2025-07-28 9:57 ` John Garry
2025-07-28 10:46 ` Johannes Thumshirn
2025-07-29 2:33 ` Martin K. Petersen [this message]
2025-08-06 2:39 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1seifn2u8.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=dlemoal@kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox