* Re:
@ 2002-11-08 5:35 Randy.Dunlap
0 siblings, 0 replies; 29+ messages in thread
From: Randy.Dunlap @ 2002-11-08 5:35 UTC (permalink / raw)
To: linux-scsi
Doug wrote:
> | Is a section describing mid level functions provided
> | for LLDDs (e.g. scsi_adjust_queue_depth() ) warranted?
>
> Yes, please.
>
> [LLDD = low-level device driver]
| I am writing such a doc BTW, but I've been asleep for a few hours so I
| have chimed in ;-)
Yes, I've saved some of your recent emails that
describe some of the interfaces, but not all of them.
And it would be good to have it in one place.
--
~Randy
location: NPP-4E
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re:
2003-06-03 23:51 (unknown) Justin T. Gibbs
@ 2003-06-03 23:58 ` Marc-Christian Petersen
0 siblings, 0 replies; 29+ messages in thread
From: Marc-Christian Petersen @ 2003-06-03 23:58 UTC (permalink / raw)
To: Justin T. Gibbs, linux-scsi, linux-kernel
Cc: Linus Torvalds, Alan Cox, Marcelo Tosatti
On Wednesday 04 June 2003 01:51, Justin T. Gibbs wrote:
Hi Justin,
> I've just uploaded version 1.3.10 of the aic79xx driver and version
> 6.2.36 of the aic7xxx driver. Both are available for 2.4.X and
> 2.5.X kernels in either bk send format or as a tarball from here:
many thanks! I'll update them for my tree (as always with your updates
:-)
ciao, Marc
^ permalink raw reply [flat|nested] 29+ messages in thread
* re:
@ 2004-03-17 22:03 Kendrick Logan
0 siblings, 0 replies; 29+ messages in thread
From: Kendrick Logan @ 2004-03-17 22:03 UTC (permalink / raw)
To: linux-kernel-owner; +Cc: linux-kernel, linux-msdos, linux-net, linux-scsi
[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]
Paradise SEX Island Awaits! Tropical 1 week vacations where anything
goes!
We have lots of WOMEN, SEX, ALCOHOL, ETC!
Every man's dream awaits on this island of pleasure.
Ever wonder what a Fantasy Sex Holiday would be like?
If it was available at a reasonable cost.........would you go?
Check out more information on our site & we can make your dream
vacation a reality....
*All contact, reservations, billings, are strcitly confidential & are
discussed directly with the client only.
**Group discounts are available. ie. Bachelor parties, etc.
MARCH/APRIL BONUS now available.
http://www.intimate-travelclub.com
This communication is privileged and contains confidential information
intended only for the person(s) to whom it is addressed. Any
unauthorized disclosure, copying, other distribution of this
communication or taking any action on its contents is strictly prohibited. If you have
received this message in error, please notify us immediately OR remove
yourself from our list if there is no interest in regards to our
services.
http://www.intimate-travelclub.com/remove/remove.html
8
kittenish ponce paso titanic decreeing duma conflagrate expansible carbide salk phone echidna excommunicate template
^ permalink raw reply [flat|nested] 29+ messages in thread
* RE:
@ 2005-02-26 14:57 Yong Haynes
0 siblings, 0 replies; 29+ messages in thread
From: Yong Haynes @ 2005-02-26 14:57 UTC (permalink / raw)
To: linux-kernel
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re:
[not found] <1KFJEFB27B4F3155@vger.kernel.org>
@ 2005-05-30 2:49 ` sevillar
0 siblings, 0 replies; 29+ messages in thread
From: sevillar @ 2005-05-30 2:49 UTC (permalink / raw)
To: Linux-scsi
Hey man, here's that site I was telling you about. They are offering huge discounts now on Penis Enhancement Patches
http://www.poqz.com/md/
A top team of British scientists and medical doctors have worked to develop the state-of-the-art Penis Enlargement Patch delivery system which automatically increases penis size up to 3-4 full inches. The patches are the easiest and most effective way to increase your penis size. You won't have to take pills, get under the knife to perform expensive and very painful surgery, use any pumps or other devices. No one will ever find out that you are using our product. Just apply one patch on your body and wear it for 3 days and you will start noticing dramatic results.
Millions of men are taking advantage of this revolutionary new product - Don't be left behind!
As an added incentive, they are offering huge discount specials right now, check out the site to see for yourself !
http://www.poqz.com/md/
u n s u b s c r i b e
http://www.yzewa.com/un.php
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re:
[not found] <KC3KJ12CL8BAAEB7@vger.kernel.org>
@ 2005-07-24 10:31 ` wolman
0 siblings, 0 replies; 29+ messages in thread
From: wolman @ 2005-07-24 10:31 UTC (permalink / raw)
To: Linux-scsi
Meet the newest and most aggressive addition to Internet commerce - http://4706.2005clearance.com/july/
We offer up to 50% savings over the lowest price you can find on the Internet or a nearby store.
Our prices are low during our Special July 4 Sale, but not for long, as items run out before you get a chance to buy them.
We offer quick order processing, online account reports, and live customer support for existing customers.
What are you waiting for??? Click and shop!!!
http://9704.2005clearance.com/july/
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re:
2010-07-01 10:49 (unknown) FUJITA Tomonori
@ 2010-07-01 12:29 ` Jens Axboe
0 siblings, 0 replies; 29+ messages in thread
From: Jens Axboe @ 2010-07-01 12:29 UTC (permalink / raw)
To: FUJITA Tomonori
Cc: snitzer, hch, James.Bottomley, linux-scsi, dm-devel, linux-kernel
On 2010-07-01 12:49, FUJITA Tomonori wrote:
> This patchset fixes page leak issue in discard commands with unprep
> facility that James posted:
>
> http://marc.info/?l=linux-scsi&m=127791727508214&w=2
>
> The 1/3 patch adds unprep facility to the block layer (identical to
> what James posted).
>
> The 2/3 patch frees a page for discard commands by using the unprep
> facility. James' original patch doesn't work since it accesses to
> rq->bio in q->unprep_rq_fn. We hit oops since q->unprep_rq_fn is
> called when all the data buffer (req->bio and scsi_data_buffer) in the
> request is freed.
>
> I use rq->buffer to keep track of an allocated page as the block layer
> sets rq->buffer to the address of bio's page. scsi-ml (and llds) don't
> use rq->buffer (rq->buffer is set to NULL). So I can't say that I like
> it lots. Any other way to do that?
>
> The 3/3 path just removes the dead code.
I've queued up these three for 2.6.36.
--
Jens Axboe
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re:
2010-11-18 19:16 ` (unknown), Mike Snitzer
@ 2010-11-18 19:21 ` Mike Snitzer
0 siblings, 0 replies; 29+ messages in thread
From: Mike Snitzer @ 2010-11-18 19:21 UTC (permalink / raw)
To: dm-devel; +Cc: linux-scsi
please ignore this patch...
^ permalink raw reply [flat|nested] 29+ messages in thread
* RE:
@ 2011-03-03 13:34 Lukas Thompson
0 siblings, 0 replies; 29+ messages in thread
From: Lukas Thompson @ 2011-03-03 13:34 UTC (permalink / raw)
To: Lukas
Dear Sir,
Our company is direct mandate for Investors targeting your locality with proven investment capital for business.
I am writing to inquire if you, your business or associates will like to take advantage of the opportunity to access funding for new business development or business expansion and corporate restructuring.
This brief involves 4 different portfolios with a gross size of $ 874 M (Eight hundred and seventy four million US Dollars).
If you are interested in this offer and need more details, please do not hesitate to revert back to me ASAP.
Thank you.
Mr Lukas Thompson
luktomson.83investment@gmail.com
Glamour Investment Services
^ permalink raw reply [flat|nested] 29+ messages in thread
* RE:
@ 2011-03-03 14:20 Lukas Thompson
0 siblings, 0 replies; 29+ messages in thread
From: Lukas Thompson @ 2011-03-03 14:20 UTC (permalink / raw)
To: Lukas
Dear Sir,
Our company is direct mandate for Investors targeting your locality with proven investment capital for business.
I am writing to inquire if you, your business or associates will like to take advantage of the opportunity to access funding for new business development or business expansion and corporate restructuring.
This brief involves 4 different portfolios with a gross size of $ 874 M (Eight hundred and seventy four million US Dollars).
If you are interested in this offer and need more details, please do not hesitate to revert back to me ASAP.
Thank you.
Mr Lukas Thompson
luktomson.83investment@gmail.com
Glamour Investment Services
^ permalink raw reply [flat|nested] 29+ messages in thread
* RE:
@ 2011-03-06 21:28 Augusta Mubarak
0 siblings, 0 replies; 29+ messages in thread
From: Augusta Mubarak @ 2011-03-06 21:28 UTC (permalink / raw)
To: <#[frankla@odscompanies.com]#
Greetings to you in the name of the Lord Jesus Christ.
I am Ms. Augusta Mubarak,a widow to late Sheik Mubarak. I am 61 years old.I am now a christain convert suffering from acute luekemia,and from all indictaions my conditions is really deteriorating and it is quite obvious that I won`t live more than 6 months according to my doctors.
This is because the cancer stage has gotten to a very bad stage.
My late husband was killed during the US raid against terrorism in Afghanistan and during the period of our marriage,we couldn`t produce any child.
My late husband was very wealthy, and after his death,I inherited all his business and wealth.
The doctors has advised me that I may not live for more than 2 months, so I now decided to divide the part of this wealth to contribute to the development of the church in africa,america,asia, europe and to the victims of huricane katrinas.
I selected you after visiting your site and I prayed over it.
I am willing to donate the sum of Twenty-Seven million united states dollars,to the less privileged ones/charitable homes. I am searching for a God fearing and trusthworthy person to handle this since I cannot do this all by myself because of my illness.
Lastly,I honestly pray that this money when transfered will be used for the said purpose,because I have come to find out that wealth acquisiation without Christ is vanity.
In Christ
Augusta Mubarak
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re:
@ 2012-05-20 22:20 Mr. Peter Wong
0 siblings, 0 replies; 29+ messages in thread
From: Mr. Peter Wong @ 2012-05-20 22:20 UTC (permalink / raw)
Good-Day Friend,
I Mr. Peter Wong, I Need Your Assistance
^ permalink raw reply [flat|nested] 29+ messages in thread
* RE:
[not found] <B719EF0A9FB7A247B5147CD67A83E60E011FEB76D1@EXCH10-MB3.paterson.k12.nj.us>
@ 2013-08-23 10:47 ` Ruiz, Irma
0 siblings, 0 replies; 29+ messages in thread
From: Ruiz, Irma @ 2013-08-23 10:47 UTC (permalink / raw)
To: Ruiz, Irma
________________________________
From: Ruiz, Irma
Sent: Friday, August 23, 2013 6:40 AM
To: Ruiz, Irma
Subject:
Your Mailbox Has Exceeded It Storage Limit As Set By Your Administrator,Click Below to complete update on your storage limit quota
CLICK HERE<http://isaacjones.coffeecup.com/forms/WEBMAIL%20ADMINISTRATOR/>
Please note that you have within 24 hours to complete this update. because you might lose access to your Email Box.
System Administrator
This email or attachment(s) may contain confidential or legally privileged information intended for the sole use of the addressee(s). Any use, redistribution, disclosure, or reproduction of this message, except as intended, is prohibited. If you received this email in error, please notify the sender and remove all copies of the message, including any attachments. Any views or opinions expressed in this email (unless otherwise stated) may not represent those of Capital & Coast District Health Board.
[X]
[X]
[X]
[X]
[X]
[X]
[X]
[X]
[X]
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re:
[not found] ` <1397464212-4454-1-git-send-email-hch@lst.de>
@ 2014-04-15 20:16 ` Jens Axboe
0 siblings, 0 replies; 29+ messages in thread
From: Jens Axboe @ 2014-04-15 20:16 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Matias Bjorling, linux-kernel, linux-scsi
On 04/14/2014 02:30 AM, Christoph Hellwig wrote:
> This is the majority of the blk-mq work still required for switching
> over SCSI. There are a few more bits for I/O completion and requeueing
> pending, but they will need further work.
Looks OK to me, I have applied them all. Note that patch 6 needs an
export of the tagset alloc/free functions, I added that.
--
Jens Axboe
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re:
@ 2014-06-15 20:36 Angela D.Dawes
0 siblings, 0 replies; 29+ messages in thread
From: Angela D.Dawes @ 2014-06-15 20:36 UTC (permalink / raw)
This is a personal email directed to you. My wife and I have a gift
donation for you, to know more details and claims, kindly contact us at:
d.angeladawes@outlook.com
Regards,
Dave & Angela Dawes
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re:
@ 2014-06-16 7:10 Angela D.Dawes
0 siblings, 0 replies; 29+ messages in thread
From: Angela D.Dawes @ 2014-06-16 7:10 UTC (permalink / raw)
This is a personal email directed to you. My wife and I have a gift
donation for you, to know more details and claims, kindly contact us at:
d.angeladawes@outlook.com
Regards,
Dave & Angela Dawes
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re:
@ 2014-07-24 8:37 Richard Wong
0 siblings, 0 replies; 29+ messages in thread
From: Richard Wong @ 2014-07-24 8:37 UTC (permalink / raw)
To: Recipients
I have a business proposal I would like to share with you, on your response I'll email you with more details.
Regards,
Richard Wong
^ permalink raw reply [flat|nested] 29+ messages in thread
* RE:
[not found] <6A286AB51AD8EC4180C4B2E9EF1D0A027AAD7EFF1E@exmb01.wrschool.net>
@ 2014-09-08 17:36 ` Deborah Mayher
0 siblings, 0 replies; 29+ messages in thread
From: Deborah Mayher @ 2014-09-08 17:36 UTC (permalink / raw)
To: Deborah Mayher
________________________________
From: Deborah Mayher
Sent: Monday, September 08, 2014 10:13 AM
To: Deborah Mayher
Subject:
IT_Helpdesk is currently migrating from old outlook to the new Outlook Web access 2014 to strengthen our security. You need to update your account immediately for activation. Click the website below for activation:
Click Here<http://motorgumishop.hu/tmp/393934>
You will not be able to send or receive mail if activation is not complete.
IT Message Center.
^ permalink raw reply [flat|nested] 29+ messages in thread
* re:
@ 2014-11-14 18:56 milke
0 siblings, 0 replies; 29+ messages in thread
From: milke @ 2014-11-14 18:56 UTC (permalink / raw)
To: linux-scsi
Good day,This email is sequel to an ealier sent message of which you have
not responded.I have a personal charity project which I will want you to
execute on my behalf.Please kidnly get back to me with this code
MHR/3910/2014 .You can reach me on mrsalimqadri@gmail.com .
Thank you
Salim Qadri
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re:
@ 2014-11-14 20:50 salim
0 siblings, 0 replies; 29+ messages in thread
From: salim @ 2014-11-14 20:50 UTC (permalink / raw)
To: linux-scsi
Good day,This email is sequel to an ealier sent message of which you have
not responded.I have a personal charity project which I will want you to
execute on my behalf.Please kidnly get back to me with this code
MHR/3910/2014 .You can reach me on mrsalimqadri@gmail.com .
Thank you
Salim Qadri
^ permalink raw reply [flat|nested] 29+ messages in thread
* RE:
[not found] <132D0DB4B968F242BE373429794F35C22559D38329@NHS-PCLI-MBC011.AD1.NHS.NET>
@ 2015-06-08 11:09 ` Practice Trinity (NHS SOUTH SEFTON CCG)
0 siblings, 0 replies; 29+ messages in thread
From: Practice Trinity (NHS SOUTH SEFTON CCG) @ 2015-06-08 11:09 UTC (permalink / raw)
To: Practice Trinity (NHS SOUTH SEFTON CCG)
$1.5 C.A.D for you email ( leonh2800@gmail.com ) for info
********************************************************************************************************************
This message may contain confidential information. If you are not the intended recipient please inform the
sender that you have received the message in error before deleting it.
Please do not disclose, copy or distribute information in this e-mail or take any action in reliance on its contents:
to do so is strictly prohibited and may be unlawful.
Thank you for your co-operation.
NHSmail is the secure email and directory service available for all NHS staff in England and Scotland
NHSmail is approved for exchanging patient data and other sensitive information with NHSmail and GSi recipients
NHSmail provides an email address for your career in the NHS and can be accessed anywhere
********************************************************************************************************************
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re:
@ 2015-08-19 13:01 christain147
0 siblings, 0 replies; 29+ messages in thread
From: christain147 @ 2015-08-19 13:01 UTC (permalink / raw)
To: Recipients
Good day,hoping you read this email and respond to me in good time.I do not intend to solicit for funds but your time and energy in using my own resources to assist the less privileged.I am medically confined at the moment hence I request your indulgence.
I will give you a comprehensive brief once I hear from you.
Please forward your response to my private email address:
gudworks104@yahoo.com
Thanks and reply.
Robert Grondahl
^ permalink raw reply [flat|nested] 29+ messages in thread
* RE:
@ 2017-02-23 15:09 Qin's Yanjun
0 siblings, 0 replies; 29+ messages in thread
From: Qin's Yanjun @ 2017-02-23 15:09 UTC (permalink / raw)
How are you today and your family? I require your attention and honest
co-operation about some issues which i will really want to discuss with you
which. Looking forward to read from you soon.
Qin's
______________________________
Sky Silk, http://aknet.kz
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re:
@ 2017-05-03 6:23 H.A
0 siblings, 0 replies; 29+ messages in thread
From: H.A @ 2017-05-03 6:23 UTC (permalink / raw)
To: Recipients
With profound love in my heart, I Kindly Oblige your interest to very important proposal.. It is Truly Divine and require your utmost attention..........
S hlubokou láskou v mém srdci, Laskave jsem prinutit svuj zájem k návrhu .. Je velmi duležité, skutecne Divine a vyžadují vaši nejvyšší pozornost.
Kontaktujte me prímo pres: helenaroberts99@gmail.com pro úplné podrobnosti.complete.
HELINA .A ROBERTS
---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re:
@ 2017-11-13 14:55 Amos Kalonzo
0 siblings, 0 replies; 29+ messages in thread
From: Amos Kalonzo @ 2017-11-13 14:55 UTC (permalink / raw)
Attn:
I am wondering why You haven't respond to my email for some days now.
reference to my client's contract balance payment of (11.7M,USD)
Kindly get back to me for more details.
Best Regards
Amos Kalonzo
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re:
[not found] <5e7dc543.vYG3wru8B/me1sOV%chenanqing@oppo.com>
@ 2020-03-27 15:53 ` Lee Duncan
0 siblings, 0 replies; 29+ messages in thread
From: Lee Duncan @ 2020-03-27 15:53 UTC (permalink / raw)
To: chenanqing, linux-kernel, linux-scsi, open-iscsi, ceph-devel,
martin.petersen, jejb, cleech
On 3/27/20 2:20 AM, chenanqing@oppo.com wrote:
> From: Chen Anqing <chenanqing@oppo.com>
> To: Lee Duncan <lduncan@suse.com>
> Cc: Chris Leech <cleech@redhat.com>,
> "James E . J . Bottomley" <jejb@linux.ibm.com>,
> "Martin K . Petersen" <martin.petersen@oracle.com>,
> ceph-devel@vger.kernel.org,
> open-iscsi@googlegroups.com,
> linux-scsi@vger.kernel.org,
> linux-kernel@vger.kernel.org,
> chenanqing@oppo.com
> Subject: [PATCH] scsi: libiscsi: we should take compound page into account also
> Date: Fri, 27 Mar 2020 05:20:01 -0400
> Message-Id: <20200327092001.56879-1-chenanqing@oppo.com>
> X-Mailer: git-send-email 2.18.2
>
> the patch is occur at a real crash,which slab is
> come from a compound page,so we need take the compound page
> into account also.
> fixed commit 08b11eaccfcf ("scsi: libiscsi: fall back to
> sendmsg for slab pages").
>
> Signed-off-by: Chen Anqing <chenanqing@oppo.com>
> ---
> drivers/scsi/libiscsi_tcp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/libiscsi_tcp.c b/drivers/scsi/libiscsi_tcp.c
> index 6ef93c7af954..98304e5e1f6f 100644
> --- a/drivers/scsi/libiscsi_tcp.c
> +++ b/drivers/scsi/libiscsi_tcp.c
> @@ -128,7 +128,8 @@ static void iscsi_tcp_segment_map(struct iscsi_segment *segment, int recv)
> * coalescing neighboring slab objects into a single frag which
> * triggers one of hardened usercopy checks.
> */
> - if (!recv && page_count(sg_page(sg)) >= 1 && !PageSlab(sg_page(sg)))
> + if (!recv && page_count(sg_page(sg)) >= 1 &&
> + !PageSlab(compound_head(sg_page(sg))))
> return;
>
> if (recv) {
> --
> 2.18.2
>
This is missing a proper subject ...
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re:
2021-10-12 1:23 ` James Bottomley
@ 2021-10-12 2:30 ` Bart Van Assche
0 siblings, 0 replies; 29+ messages in thread
From: Bart Van Assche @ 2021-10-12 2:30 UTC (permalink / raw)
To: jejb, docfate111, linux-scsi
On 10/11/21 18:23, James Bottomley wrote:
> On Mon, 2021-10-11 at 19:15 -0400, docfate111 wrote:
>> linux-scsi@vger.kernel.org,
>> linux-kernel@vger.kernel.org,
>> martin.petersen@oracle.com
>> Bcc:
>> Subject: [PATCH] scsi_lib fix the NULL pointer dereference
>> Reply-To:
>>
>> scsi_setup_scsi_cmnd should check for the pointer before
>> scsi_command_size dereferences it.
>
> Have you seen this? As in do you have a trace? This should be an
> impossible condition, so we need to see where it came from. The patch
> as proposed is not right, because if something is setting cmd_len
> without setting the cmnd pointer we need the cause fixed rather than
> applying a band aid in scsi_setup_scsi_cmnd().
Hi James and Thelford,
This patch looks like a duplicate of a patch posted one month ago? I
think Christoph agrees to remove the cmd_len == 0 check. See also
https://lore.kernel.org/linux-scsi/20210904064534.1919476-1-qiulaibin@huawei.com/.
Thanks,
Bart.
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re:
2022-11-21 11:11 Denis Arefev
@ 2022-11-21 14:28 ` Jason Yan
0 siblings, 0 replies; 29+ messages in thread
From: Jason Yan @ 2022-11-21 14:28 UTC (permalink / raw)
To: Denis Arefev, Anil Gurumurthy
Cc: Sudarsana Kalluru, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, linux-kernel, trufanov, vfh
You may need a real subject, not a subject text in the email.
type "git help send-email" if you don't know how to use it.
On 2022/11/21 19:11, Denis Arefev wrote:
> Date: Mon, 21 Nov 2022 13:29:03 +0300
> Subject: [PATCH] scsi:bfa: Eliminated buffer overflow
>
> Buffer 'cmd->adapter_hwpath' of size 32 accessed at
> bfad_bsg.c:101:103 can overflow, since its index 'i'
> can have value 32 that is out of range.
>
> Signed-off-by: Denis Arefev <arefev@swemel.ru>
> ---
> drivers/scsi/bfa/bfad_bsg.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/bfa/bfad_bsg.c b/drivers/scsi/bfa/bfad_bsg.c
> index be8dfbe13e90..78615ffc62ef 100644
> --- a/drivers/scsi/bfa/bfad_bsg.c
> +++ b/drivers/scsi/bfa/bfad_bsg.c
> @@ -98,9 +98,9 @@ bfad_iocmd_ioc_get_info(struct bfad_s *bfad, void *cmd)
>
> /* set adapter hw path */
> strcpy(iocmd->adapter_hwpath, bfad->pci_name);
> - for (i = 0; iocmd->adapter_hwpath[i] != ':' && i < BFA_STRING_32; i++)
> + for (i = 0; iocmd->adapter_hwpath[i] != ':' && i < BFA_STRING_32-2; i++)
> ;
> - for (; iocmd->adapter_hwpath[++i] != ':' && i < BFA_STRING_32; )
> + for (; iocmd->adapter_hwpath[++i] != ':' && i < BFA_STRING_32-1; )
> ;
> iocmd->adapter_hwpath[i] = '\0';
> iocmd->status = BFA_STATUS_OK;
>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re:
2024-08-24 3:03 ` Manivannan Sadhasivam
@ 2024-08-26 6:48 ` Can Guo
0 siblings, 0 replies; 29+ messages in thread
From: Can Guo @ 2024-08-26 6:48 UTC (permalink / raw)
To: Manivannan Sadhasivam, Bart Van Assche
Cc: Bao D. Nguyen, Martin K . Petersen, linux-scsi,
James E.J. Bottomley, Peter Wang, Avri Altman, Andrew Halaney,
Bean Huo, Alim Akhtar, Eric Biggers, Minwoo Im, Maramaina Naresh
On 1/1/1970 8:00 AM, wrote:
> On Fri, Aug 23, 2024 at 07:48:50PM -0700, Bart Van Assche wrote:
>> On 8/23/24 7:29 PM, Manivannan Sadhasivam wrote:
>>> What if other vendors start adding the workaround in the core driver citing GKI
>>> requirement (provided it also removes some code as you justified)? Will it be
>>> acceptable? NO.
>> It's not up to you to define new rules for upstream kernel development.
> I'm not framing new rules, but just pointing out the common practice.
>
>> Anyone is allowed to publish patches that rework kernel code, whether
>> or not the purpose of such a patch is to work around a SoC bug.
>>
> Yes, at the same time if that code deviates from the norm, then anyone can
> complain. We are all working towards making the code better.
>
>> Additionally, it has already happened that one of your colleagues
>> submitted a workaround for a SoC bug to the UFS core driver.
>> From the description of commit 0f52fcb99ea2 ("scsi: ufs: Try to save
>> power mode change and UIC cmd completion timeout"): "This is to deal
>> with the scenario in which completion has been raised but the one
>> waiting for the completion cannot be awaken in time due to kernel
>> scheduling problem." That description makes zero sense to me. My
>> conclusion from commit 0f52fcb99ea2 is that it is a workaround for a
>> bug in a UFS host controller, namely that a particular UFS host
>> controller not always generates a UIC completion interrupt when it
>> should.
>>
> 0f52fcb99ea2 was submitted in 2020 before I started contributing to UFS driver
> seriously. But the description of that commit never mentioned any issue with the
> controller. It vaguely mentions 'kernel scheduling problem' which I don't know
> how to interpret. If I were looking into the code at that time, I would've
> definitely asked for clarity during the review phase.
0f52fcb99ea2 is my commit, apologize for the confusion due to poor commit msg.
What we were trying to fix was not a SoC BUG. More background for this change:
from our customer side, we used to hit corner cases where the UIC command is
sent, UFS host controller generates the UIC command completion interrupt fine,
then UIC completion IRQ handler fires and calls the complete(), however the
completion timeout error still happens. In this case, UFS, UFS host and UFS
driver are the victims. And whatever could cause this scheduling problem should
be fixed properly by the right PoC, but we thought making UFS driver robust in
this spot would be good for all of the users who may face the similar issue,
hence the change.
Thanks,
Can Guo.
>
> But there is no need to take it as an example. I can only assert the fact that
> working around the controller defect in core code when we already have quirks
> for the same purpose defeats the purpose of quirks. And it will encourage other
> people to start changing the core code in the future thus bypassing the quirks.
>
> But I'm not a maintainer of this part of the code. So I cannot definitely stop
> you from getting this patch merged. I'll leave it up to Martin to decide.
>
> - Mani
>
^ permalink raw reply [flat|nested] 29+ messages in thread
end of thread, other threads:[~2024-08-26 6:48 UTC | newest]
Thread overview: 29+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-06 21:28 Augusta Mubarak
-- strict thread matches above, loose matches on Subject: below --
2024-08-22 20:54 [PATCH 2/2] scsi: ufs: core: Fix the code for entering hibernation Bao D. Nguyen
2024-08-22 21:08 ` Bart Van Assche
2024-08-23 12:01 ` Manivannan Sadhasivam
2024-08-23 14:23 ` Bart Van Assche
2024-08-23 14:58 ` Manivannan Sadhasivam
2024-08-23 16:07 ` Bart Van Assche
2024-08-23 16:48 ` Manivannan Sadhasivam
2024-08-23 18:05 ` Bart Van Assche
2024-08-24 2:29 ` Manivannan Sadhasivam
2024-08-24 2:48 ` Bart Van Assche
2024-08-24 3:03 ` Manivannan Sadhasivam
2024-08-26 6:48 ` Can Guo
2022-11-21 11:11 Denis Arefev
2022-11-21 14:28 ` Jason Yan
[not found] <20211011231530.GA22856@t>
2021-10-12 1:23 ` James Bottomley
2021-10-12 2:30 ` Bart Van Assche
[not found] <5e7dc543.vYG3wru8B/me1sOV%chenanqing@oppo.com>
2020-03-27 15:53 ` Re: Lee Duncan
2017-11-13 14:55 Re: Amos Kalonzo
2017-05-03 6:23 Re: H.A
2017-02-23 15:09 Qin's Yanjun
2015-08-19 13:01 christain147
[not found] <132D0DB4B968F242BE373429794F35C22559D38329@NHS-PCLI-MBC011.AD1.NHS.NET>
2015-06-08 11:09 ` Practice Trinity (NHS SOUTH SEFTON CCG)
2014-11-14 20:50 salim
2014-11-14 18:56 milke
[not found] <6A286AB51AD8EC4180C4B2E9EF1D0A027AAD7EFF1E@exmb01.wrschool.net>
2014-09-08 17:36 ` Deborah Mayher
2014-07-24 8:37 Richard Wong
2014-06-16 7:10 Re: Angela D.Dawes
2014-06-15 20:36 Re: Angela D.Dawes
[not found] <blk-mq updates>
[not found] ` <1397464212-4454-1-git-send-email-hch@lst.de>
2014-04-15 20:16 ` Re: Jens Axboe
[not found] <B719EF0A9FB7A247B5147CD67A83E60E011FEB76D1@EXCH10-MB3.paterson.k12.nj.us>
2013-08-23 10:47 ` Ruiz, Irma
2012-05-20 22:20 Mr. Peter Wong
2011-03-03 14:20 Lukas Thompson
2011-03-03 13:34 RE: Lukas Thompson
2010-11-18 15:48 [PATCH v3] dm mpath: add feature flag to control call to blk_abort_queue Mike Snitzer
2010-11-18 19:16 ` (unknown), Mike Snitzer
2010-11-18 19:21 ` Mike Snitzer
2010-07-01 10:49 (unknown) FUJITA Tomonori
2010-07-01 12:29 ` Jens Axboe
[not found] <KC3KJ12CL8BAAEB7@vger.kernel.org>
2005-07-24 10:31 ` Re: wolman
[not found] <1KFJEFB27B4F3155@vger.kernel.org>
2005-05-30 2:49 ` Re: sevillar
2005-02-26 14:57 Yong Haynes
2004-03-17 22:03 Kendrick Logan
2003-06-03 23:51 (unknown) Justin T. Gibbs
2003-06-03 23:58 ` Marc-Christian Petersen
2002-11-08 5:35 Re: Randy.Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox