From: Himanshu Madhani <hmadhani@marvell.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
Roman Bolshakov <r.bolshakov@yadro.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Quinn Tran <qutran@marvell.com>
Subject: Re: [EXT] Re: [PATCH] Revert "qla2xxx: Fix Nport ID display value"
Date: Tue, 10 Dec 2019 19:38:59 +0000 [thread overview]
Message-ID: <BEF43C75-37EE-44FB-984E-F70BAE351B73@marvell.com> (raw)
In-Reply-To: <yq1fthtqe93.fsf@oracle.com>
Hi Bart/Martin/Roman,
On 12/9/19, 5:19 PM, "Martin K. Petersen" <martin.petersen@oracle.com> wrote:
External Email
----------------------------------------------------------------------
>> Firmware can do implicit login, and this is how it worked for a
>> while.
>>
>> Then explicit login was introduced in the commit you referenced by
>> setting bit 8 in IFCB fimwrare options 3 for 2600/2700 series and
>> issuing ELS IOCB. However, for 2500 series, bit 7 should be set to
>> disable implicit logins.
>>
>> The latest commits that touches the bit is 8777e4314d397 ("scsi:
>> qla2xxx: Migrate NVME N2N handling into state machine"). It sets the
>> bit in qla24xx_nvram_config regadless of chip.
>>
>> Does it help to set bit 7 in IFCB, firmware options 3 for 2500 series
>> and leave the RESERVED S_ID field untouched?
Himanshu: Please advise on how to fix this regression.
I reviewed the series sent earlier this morning which had revised version of this patch. I am okay with that change (I'll ack on that patch separately from this thread). Basically with newer patch submitted today, we are reverting to older method of handling N2N login for ISP 25xx.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2019-12-10 19:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-09 4:21 [PATCH] Revert "qla2xxx: Fix Nport ID display value" Bart Van Assche
2019-11-11 11:28 ` Roman Bolshakov
2019-11-12 2:48 ` Bart Van Assche
2019-11-13 15:29 ` Himanshu Madhani
2019-11-14 2:34 ` Bart Van Assche
2019-11-20 0:15 ` Bart Van Assche
2019-11-20 21:39 ` Himanshu Madhani
2019-11-21 3:26 ` Bart Van Assche
2019-12-02 16:40 ` Bart Van Assche
2019-12-02 20:55 ` Roman Bolshakov
2019-12-03 2:34 ` Bart Van Assche
2019-12-04 12:07 ` Roman Bolshakov
2019-12-06 6:03 ` Bart Van Assche
2019-12-09 23:18 ` Martin K. Petersen
2019-12-10 19:38 ` Himanshu Madhani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BEF43C75-37EE-44FB-984E-F70BAE351B73@marvell.com \
--to=hmadhani@marvell.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=qutran@marvell.com \
--cc=r.bolshakov@yadro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox