* [patch 1/7] scsi/mesh: replace schedule_timeout() with msleep()
@ 2004-09-01 19:54 janitor
0 siblings, 0 replies; only message in thread
From: janitor @ 2004-09-01 19:54 UTC (permalink / raw)
To: linux-scsi; +Cc: James.Bottomley, janitor
I would appreciate any comments from the janitor@sternweltens list.
Description: Use msleep() instead of schedule_timeout() to
guarantee the task delays for the desired time.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
---
linux-2.6.9-rc1-bk7-max/drivers/scsi/mesh.c | 12 ++++--------
1 files changed, 4 insertions(+), 8 deletions(-)
diff -puN drivers/scsi/mesh.c~msleep-drivers_scsi_mesh drivers/scsi/mesh.c
--- linux-2.6.9-rc1-bk7/drivers/scsi/mesh.c~msleep-drivers_scsi_mesh 2004-09-01 19:35:45.000000000 +0200
+++ linux-2.6.9-rc1-bk7-max/drivers/scsi/mesh.c 2004-09-01 19:35:45.000000000 +0200
@@ -388,8 +388,7 @@ static void mesh_init(struct mesh_state
mesh_flush_io(mr);
/* Wait for bus to come back */
- current->state = TASK_UNINTERRUPTIBLE;
- schedule_timeout((init_reset_delay * HZ) / 1000);
+ msleep(init_reset_delay);
}
/* Reconfigure controller */
@@ -1749,12 +1748,10 @@ static void set_mesh_power(struct mesh_s
return;
if (state) {
pmac_call_feature(PMAC_FTR_MESH_ENABLE, macio_get_of_node(ms->mdev), 0, 1);
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(HZ/5);
+ msleep(200);
} else {
pmac_call_feature(PMAC_FTR_MESH_ENABLE, macio_get_of_node(ms->mdev), 0, 0);
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(HZ/100);
+ msleep(10);
}
}
@@ -1772,8 +1769,7 @@ static int mesh_suspend(struct macio_dev
spin_lock_irqsave(ms->host->host_lock, flags);
while(ms->phase != idle) {
spin_unlock_irqrestore(ms->host->host_lock, flags);
- current->state = TASK_UNINTERRUPTIBLE;
- schedule_timeout(HZ/100);
+ msleep(10);
spin_lock_irqsave(ms->host->host_lock, flags);
}
ms->phase = sleeping;
_
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-09-01 19:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-01 19:54 [patch 1/7] scsi/mesh: replace schedule_timeout() with msleep() janitor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox