public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* [patch 5/7]  scsi/sata_sx4: replace schedule_timeout()  with msleep()
@ 2004-09-01 19:55 janitor
  0 siblings, 0 replies; only message in thread
From: janitor @ 2004-09-01 19:55 UTC (permalink / raw)
  To: linux-scsi; +Cc: James.Bottomley, janitor







I would appreciate any comments from the janitor@sternweltens list. 



Description: Use msleep() instead of schedule_timeout() to 
guarantee the task delays for the desired time.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>



---

 linux-2.6.9-rc1-bk7-max/drivers/scsi/sata_sx4.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff -puN drivers/scsi/sata_sx4.c~msleep-drivers_scsi_sata_sx4 drivers/scsi/sata_sx4.c
--- linux-2.6.9-rc1-bk7/drivers/scsi/sata_sx4.c~msleep-drivers_scsi_sata_sx4	2004-09-01 19:35:48.000000000 +0200
+++ linux-2.6.9-rc1-bk7-max/drivers/scsi/sata_sx4.c	2004-09-01 19:35:48.000000000 +0200
@@ -1189,8 +1189,7 @@ static unsigned int pdc20621_prog_dimm_g
 	   		error = 0;
 	   		break;     
 		}
-		set_current_state(TASK_UNINTERRUPTIBLE);
-		schedule_timeout((i * 100) * HZ / 1000 + 1);
+		msleep(i*100);
    	}
    	return error;
 }
@@ -1223,8 +1222,7 @@ static unsigned int pdc20621_dimm_init(s
 	readl(mmio + PDC_TIME_CONTROL);
 
 	/* Wait 3 seconds */
-	set_current_state(TASK_UNINTERRUPTIBLE);
-	schedule_timeout(3 * HZ);
+	msleep(3000);
 
 	/* 
 	   When timer is enabled, counter is decreased every internal

_

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-09-01 19:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-01 19:55 [patch 5/7] scsi/sata_sx4: replace schedule_timeout() with msleep() janitor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox