From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Justin Tee <justin.tee@broadcom.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>
Subject: Re: [PATCH v1 1/1] scsi: lpfc: Switch to use %ptTs
Date: Thu, 6 Feb 2025 20:57:26 +0200 [thread overview]
Message-ID: <Z6UGFoJbAGjI5VJW@smile.fi.intel.com> (raw)
In-Reply-To: <20250206174537-a38cd6ae-e0fe-4344-8655-2593e20fd394@linutronix.de>
On Thu, Feb 06, 2025 at 05:52:16PM +0100, Thomas Weißschuh wrote:
> On Thu, Feb 06, 2025 at 05:58:22PM +0200, Andy Shevchenko wrote:
...
> > lpfc_printf_log(phba, KERN_INFO, LOG_CGN_MGMT,
> > - "2646 Updated CMF timestamp : "
> > - "%u/%u/%u %u:%u:%u\n",
> > - ts->day, ts->month,
> > - ts->year, ts->hour,
> > - ts->minute, ts->second);
> > + "2646 Updated CMF timestamp : %ptTs\n", cur_time);
>
> All %p<FOO> arguments need to be addresses.
> Also %ptT wants a time64_t, not a 'struct timespec64'.
> It would work by chance because tv_sec is the first member and time64_t.
>
> Correct: "&cur_time.tv_sec".
Indeed, thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-02-06 18:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 15:58 [PATCH v1 1/1] scsi: lpfc: Switch to use %ptTs Andy Shevchenko
2025-02-06 16:52 ` Thomas Weißschuh
2025-02-06 18:57 ` Andy Shevchenko [this message]
2025-02-06 18:16 ` Justin Tee
2025-02-06 18:57 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6UGFoJbAGjI5VJW@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dick.kennedy@broadcom.com \
--cc=james.smart@broadcom.com \
--cc=justin.tee@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox