From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Justin Tee <justintee8345@gmail.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Justin Tee <justin.tee@broadcom.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>
Subject: Re: [PATCH v1 1/1] scsi: lpfc: Switch to use %ptTs
Date: Thu, 6 Feb 2025 20:57:51 +0200 [thread overview]
Message-ID: <Z6UGL5P-ws9prRBA@smile.fi.intel.com> (raw)
In-Reply-To: <CABPRKS-7c+8sQPzYugAeQ5OeC6P82XGDjKowkoJZFNaQz59CBw@mail.gmail.com>
On Thu, Feb 06, 2025 at 10:16:09AM -0800, Justin Tee wrote:
> Hi Andy,
>
> The purpose of the lpfc_cgn_update_tstamp routine is more than just
> printf. The *ts pointer argument is updated with cur_time, and is
> typically a pointer to a global statistics struct used by the device
> driver in various contexts. Sorry, but we can’t remove the lines
> suggested in this patch.
Ah, you are right, the ts is used somewhere else.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-02-06 18:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 15:58 [PATCH v1 1/1] scsi: lpfc: Switch to use %ptTs Andy Shevchenko
2025-02-06 16:52 ` Thomas Weißschuh
2025-02-06 18:57 ` Andy Shevchenko
2025-02-06 18:16 ` Justin Tee
2025-02-06 18:57 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6UGL5P-ws9prRBA@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dick.kennedy@broadcom.com \
--cc=james.smart@broadcom.com \
--cc=justin.tee@broadcom.com \
--cc=justintee8345@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox