* Re: [PATCH v2] scsi: iscsi: kfree_sensitive() in iscsi_session_free()
[not found] <20230719074534.5311-1-duminjie@vivo.com>
@ 2023-07-19 17:47 ` Chris Leech
2023-07-23 16:44 ` Mike Christie
1 sibling, 0 replies; 2+ messages in thread
From: Chris Leech @ 2023-07-19 17:47 UTC (permalink / raw)
To: 杜敏杰
Cc: Lee Duncan, Mike Christie, James E.J. Bottomley,
Martin K. Petersen, open list:ISCSI, open list:ISCSI, open list,
opensource.kernel
On Wed, Jul 19, 2023 at 07:45:48AM +0000, 杜敏杰 wrote:
> session might contain private part of the password, so better use
> kfree_sensitive() to free it.
> In iscsi_session_free() use kfree_sensitive() to free session->password,
> session->password_in, session->username, session->username_in.
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
This looks good, thank you for the follow up to Mike's review.
Reviewed-by: Chris Leech <cleech@redhat.com>
> ---
> drivers/scsi/libiscsi.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index 0fda8905e..a307da898 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -3132,10 +3132,10 @@ void iscsi_session_free(struct iscsi_cls_session *cls_session)
> struct module *owner = cls_session->transport->owner;
>
> iscsi_pool_free(&session->cmdpool);
> - kfree(session->password);
> - kfree(session->password_in);
> - kfree(session->username);
> - kfree(session->username_in);
> + kfree_sensitive(session->password);
> + kfree_sensitive(session->password_in);
> + kfree_sensitive(session->username);
> + kfree_sensitive(session->username_in);
> kfree(session->targetname);
> kfree(session->targetalias);
> kfree(session->initiatorname);
> --
> 2.39.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] scsi: iscsi: kfree_sensitive() in iscsi_session_free()
[not found] <20230719074534.5311-1-duminjie@vivo.com>
2023-07-19 17:47 ` [PATCH v2] scsi: iscsi: kfree_sensitive() in iscsi_session_free() Chris Leech
@ 2023-07-23 16:44 ` Mike Christie
1 sibling, 0 replies; 2+ messages in thread
From: Mike Christie @ 2023-07-23 16:44 UTC (permalink / raw)
To: 杜敏杰, Lee Duncan, Chris Leech,
James E.J. Bottomley, Martin K. Petersen, open list:ISCSI,
open list:ISCSI, open list
Cc: opensource.kernel
On 7/19/23 2:45 AM, 杜敏杰 wrote:
> session might contain private part of the password, so better use
> kfree_sensitive() to free it.
> In iscsi_session_free() use kfree_sensitive() to free session->password,
> session->password_in, session->username, session->username_in.
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
> drivers/scsi/libiscsi.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index 0fda8905e..a307da898 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -3132,10 +3132,10 @@ void iscsi_session_free(struct iscsi_cls_session *cls_session)
> struct module *owner = cls_session->transport->owner;
>
> iscsi_pool_free(&session->cmdpool);
> - kfree(session->password);
> - kfree(session->password_in);
> - kfree(session->username);
> - kfree(session->username_in);
> + kfree_sensitive(session->password);
> + kfree_sensitive(session->password_in);
> + kfree_sensitive(session->username);
> + kfree_sensitive(session->username_in);
> kfree(session->targetname);
> kfree(session->targetalias);
> kfree(session->initiatorname);
Reviewed-by: Mike Christie <michael.christie@oracle.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-23 16:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230719074534.5311-1-duminjie@vivo.com>
2023-07-19 17:47 ` [PATCH v2] scsi: iscsi: kfree_sensitive() in iscsi_session_free() Chris Leech
2023-07-23 16:44 ` Mike Christie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox