From: Christoph Hellwig <hch@infradead.org>
To: Li Feng <fengli@smartx.com>
Cc: "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:SCSI SUBSYSTEM" <linux-scsi@vger.kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] scsi: sd: Keep the discard mode stable
Date: Sun, 16 Jun 2024 23:17:33 -0700 [thread overview]
Message-ID: <Zm_U_ZA96u2K6a6S@infradead.org> (raw)
In-Reply-To: <20240614160350.180490-1-fengli@smartx.com>
On Sat, Jun 15, 2024 at 12:03:47AM +0800, Li Feng wrote:
> + /*
> + * When the discard mode has been set to UNMAP, it should not be set to
Overly long line here.
> + * WRITE SAME with UNMAP.
> + */
> + if (!sdkp->max_unmap_blocks)
> + sd_config_discard(sdkp, SD_LBP_WS16);
But more importantly this doesn't really scale to all the variations
of reported / guessed at probe time vs overriden. I think you just
need an explicit override flag that skips the discard settings.
next prev parent reply other threads:[~2024-06-17 6:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 16:03 [PATCH] scsi: sd: Keep the discard mode stable Li Feng
2024-06-17 6:17 ` Christoph Hellwig [this message]
2024-06-17 9:03 ` Li Feng
2024-06-18 6:41 ` Christoph Hellwig
2024-06-19 6:56 ` Li Feng
2024-06-19 7:02 ` Christoph Hellwig
2024-06-17 16:26 ` Benjamin Block
2024-06-18 3:06 ` Li Feng
2024-06-18 8:47 ` Benjamin Block
2024-06-19 6:58 ` Li Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zm_U_ZA96u2K6a6S@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=fengli@smartx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox