From: Christoph Hellwig <hch@infradead.org>
To: Li Feng <fengli@smartx.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] scsi: sd: Keep the discard mode stable
Date: Wed, 19 Jun 2024 00:02:44 -0700 [thread overview]
Message-ID: <ZnKClE0RimoZFQSB@infradead.org> (raw)
In-Reply-To: <D8A1CB7B-7DE5-4078-9640-8674278E34C8@smartx.com>
On Wed, Jun 19, 2024 at 02:56:18PM +0800, Li Feng wrote:
> + sd_config_discard(sdkp, &lim, sd_discard_mode(sdkp));
>
> sd_print_capacity(sdkp, old_capacity);
>
>
> If it's OK, I'll submit v2.
Except for the whitespace damage in the moved call this looks good
to me.
next prev parent reply other threads:[~2024-06-19 7:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 16:03 [PATCH] scsi: sd: Keep the discard mode stable Li Feng
2024-06-17 6:17 ` Christoph Hellwig
2024-06-17 9:03 ` Li Feng
2024-06-18 6:41 ` Christoph Hellwig
2024-06-19 6:56 ` Li Feng
2024-06-19 7:02 ` Christoph Hellwig [this message]
2024-06-17 16:26 ` Benjamin Block
2024-06-18 3:06 ` Li Feng
2024-06-18 8:47 ` Benjamin Block
2024-06-19 6:58 ` Li Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnKClE0RimoZFQSB@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=fengli@smartx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox