* Re: [PATCH 1/2] block: also mark disk-owned queues as dying in __blk_mark_disk_dead
[not found] ` <20241016123240.GB18219@lst.de>
@ 2024-10-16 12:49 ` Ming Lei
0 siblings, 0 replies; only message in thread
From: Ming Lei @ 2024-10-16 12:49 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Sergey Senozhatsky, YangYang, linux-block, linux-scsi,
Martin K. Petersen
On Wed, Oct 16, 2024 at 02:32:40PM +0200, Christoph Hellwig wrote:
> On Wed, Oct 16, 2024 at 07:09:48PM +0800, Ming Lei wrote:
> > Setting QUEUE_FLAG_DYING may fail passthrough request for
> > !GD_OWNS_QUEUE, I guess this may cause SCSI regression.
>
> Yes, as clearly documented in the commit log.
The change need Cc linux-scsi.
> As the disk is going away there is no real point in sending these
> commands, but we have no really good way to distinguish between the
> cases.
scsi request queue has very different lifetime with gendisk, not sure the
above comment is correct.
Thanks,
Ming
^ permalink raw reply [flat|nested] only message in thread